Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #264

Merged
merged 2 commits into from
Jun 5, 2024
Merged

update dependencies #264

merged 2 commits into from
Jun 5, 2024

Conversation

gabor
Copy link

@gabor gabor commented Jun 3, 2024

we update the sqlds dependency to it's newest version ( we want the feature where the "executed query string" is returned even when there is an error, this makes debugging queries with macros a lot easier: grafana/sqlds#117 ).

we had to handle a deprecation-warning, had to replace sqlds.Query with sqlutil.query

and we also update the plugin-sdk-go to it's newest version.

@gabor gabor requested a review from a team as a code owner June 3, 2024 12:45
@gabor gabor requested review from yesoreyeram, zoltanbedi and gwdawson and removed request for a team June 3, 2024 12:45
Copy link

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for tomorrow's go release and we can release together.

@gabor
Copy link
Author

gabor commented Jun 4, 2024

hi @yesoreyeram , could you re-review it please? i had to add one more commit, sqlds.Query is now deprecated, so the linter complained, it has to be replaced with sqlutil.Query.

@gabor gabor requested a review from yesoreyeram June 4, 2024 07:30
Copy link

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabor gabor merged commit 985d656 into main Jun 5, 2024
3 checks passed
@gabor gabor deleted the gabor/update-deps branch June 5, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants