feat: add headlessService for grafana high availability #1840
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synthe102
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
|
|
github-actions
bot
added
the
documentation
synthe102
force-pushed
the
master
branch
3 times, most recently
from
939b564 to
6b4d76e
Compare
|
@synthe102 thanks for the PR, could you create some e2e test as well? Just to see that the yaml gets generated as intended |
|
Sure ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the steps described in the Grafana documentation to configure a HA grafana:
POD_IPenvironment variable from downward APIWhile most of it can already be added manually with overrides in the CR, the headless service has to be manually created. I think that providing all the key components to run a HA Grafana makes sense.
The "Multiple replicas" doc example has also been updated to include a config snippet for HA setup.