-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a Dashboard for Monitoring the Operator Metrics #1860
base: master
Are you sure you want to change the base?
Conversation
It feels so wrong using a configmap for the grafana-operator when the whole point of the operator is to not use configmaps 😄 But I understand that we get a chicken and egg issue. we can't create grafana-operator CRDs as part of the helm chart. But I do think we should document how to actually use this dashboard, with calling it from a CRD. On the implementation side, I would suggest storing the pure json as a file, and call on it from helm: https://helm.sh/docs/chart_template_guide/accessing_files/#basic-example This way you can easily copy and paste in new versions and it's a bit cleaner to read in my mind. |
+1 on the splitting up into a separate JSON file. That way we can also provide docs on how to include this dashboard using a remote reference for those who don't manage the operator using helm |
Thank you for your feedback! I’ve updated the ConfigMap template to fetch the JSON definition from a dedicated file, as requested. I also enhanced the Values comments to include at least a mention of the Grafana.com URL and the dashboard ID. Would you like me to add or modify an existing documentation page to cover the alternative method of deploying the Dashboard using an operator-managed CR? If so, which page in your opinion, would make the most sense for this to be mentioned in ? |
I think this could live on the same level as the installation guides with a title like Happy to hear out other suggestions though |
c7f8f3f
to
f4670b8
Compare
The doc page looks good! The last thing I'd add here, is an example |
Done 😄 |
With this PR I'm adding the possibility to create a ConfigMap containing a Dashboard definition leveraging the operator metrics, based on a new set of Helm Values.
The new dashboard is based on this one.
Closes #653
@theSuess Could you please have a look ?
Feel free to mention any changes you see that could make sense.