fix(Grafana): CreateContainerConfigError with disableDefaultAdminSecret and admin secret missing
#2356
+17
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
changed the title
CreateContainerConfigError with disableDefaultAdminSecret and admin secret missing
…e` and admin secret is missing
Baarsgaard
force-pushed
the
fix_cannot_create_pod_without_admin_secret
branch
from
596b09e to
d75972e
Compare
Baarsgaard
force-pushed
the
fix_cannot_create_pod_without_admin_secret
branch
from
f1f7919 to
5989d68
Compare
Baarsgaard
requested review from
hubeadmin,
ishanjainn,
nissessenap,
pb82,
theSuess and
weisdd
as code owners
weisdd
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing #2335 I found that setting
.spec.disableDefaultAdminSecret=trueon the first apply would fail.The deployment would be invalid as the admin secret would be skipped, but the environment variables of the instance would still reference the secret.
To test for this I re-arranged the E2E tests a bit.
It was not possible to disable the admin secret on the internal instance without also changing the external one to use JWT as a login.
Hence, the default
grafanainstance enablesuseKubeAuthand changed the role assignment to use thesubfield to narrow it down.