feat: add alerting #138
Merged
feat: add alerting #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
approved these changes
Oct 13, 2023
| }, | ||
| }, | ||
|
|
||
| // Add isPaused to ProvisionedAlertRule, this is missing in v9.4.0 |
There was a problem hiding this comment.
do these fixups have issues upstream? be good to include references
There was a problem hiding this comment.
This is for v9.4.0, so not bothering, schema fixes have generally not been backported in grafana/grafana.
The whole library is still marked as experimental, the note is just there to say 'we know this is incomplete'. |
Duologic
force-pushed
the
duologic/alerting
branch
from
f85461c to
71001c3
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
This PR provides an interface to create Alerting provisioning resources with Grafonnet. I personally don't know if we have a client that can actually do something with these JSON resources but at least we have one part of the puzzle this way.
The Grafonnet API is modelled after the Terraform provider resources. The
contactPointschema is under development so we can't offer that in Grafonnet properly yet.The schema's for these resources come from the Grafana OpenAPI spec, this opens the door to add more resources that are described in this specification.
As always I tend to make this reviewable commit-by-commit. First commit is the actual code for the generator, the other two are generating the code and docs.