[grafana] Enhance Deployment Template Flexibility for Zero Replicas #2866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anotherglitchinthematrix
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
zanhsieh
changed the title
Signed-off-by: Ali Can YILDIZ <anotherglitchinthematrix@gmail.com>
zanhsieh
suggested changes
Feb 8, 2024
There was a problem hiding this comment.
@anotherglitchinthematrix
Can you bump the version in Chart.yaml and sign DCO please?
Signed-off-by: MH <zanhsieh@gmail.com>
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Dec 19, 2024
jkroepke
reviewed
Dec 20, 2024
|
This issue seems to be resolved in the recent versions after merging of #3337 This PR was fixing the falsy evaluation of the - {{- if and (not .Values.autoscaling.enabled) (.Values.replicas) }}
+ {{- if and (not .Values.autoscaling.enabled) (hasKey .Values "replicas") }}The current conditional block eliminated that case. {{- if (not .Values.autoscaling.enabled) }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered an issue while attempting to deploy the Grafana chart with zero replicas. The problem arises from the replicas value being set to zero, which falsifies an if block in the deployment template, leading Kubernetes to default to a replication count of 1.
This pattern is not unique and is present in multiple deployment templates across the repository. The current implementation limits configuration options for manual intervention, restricting users from customizing the replication count as needed.
I suggest modifying this pattern in other deployment templates within the repository to improve consistency and provide users with greater flexibility in their configurations.
The current pattern undermines some configuration opportunities for manual intervention, hindering users from tailoring deployment settings according to their specific requirements.
Your feedback on these proposed changes is highly appreciated. Please share your thoughts on whether this modification aligns with our goals for configuration flexibility. Let's discuss the best approach to enhance the user experience in managing deployments.