Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-operator] Add support for namespace in deployment template. #3154

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

Sheikh-Abubaker
Copy link
Collaborator

Fixes #2880 and #2938

Signed-off-by: Sheikh-Abubaker <sheikhabubaker761@gmail.com>
@Sheikh-Abubaker Sheikh-Abubaker changed the title [agent-operator] Add missing namespace in deployment template. [agent-operator] Add missing namespace in deployment template. Jun 5, 2024
Signed-off-by: Sheikh-Abubaker <sheikhabubaker761@gmail.com>
@Sheikh-Abubaker
Copy link
Collaborator Author

@zalegrala @zanhsieh please check this new PR it has passed all the checks which the previous PR didn't.

Signed-off-by: Sheikh-Abubaker <sheikhabubaker761@gmail.com>
@zanhsieh zanhsieh merged commit cc9f1b4 into grafana:main Jun 8, 2024
6 checks passed
@Sheikh-Abubaker Sheikh-Abubaker changed the title [agent-operator] Add missing namespace in deployment template. [agent-operator] Add Add support for namespace in deployment template. Jun 8, 2024
@Sheikh-Abubaker Sheikh-Abubaker changed the title [agent-operator] Add Add support for namespace in deployment template. [agent-operator] Add support for namespace in deployment template. Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm templating inconsistency with --namespace flag
3 participants