Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tempo-distributed] add log_discarded_spans config for Tempo distributor to tempo-distrib… #3289

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[tempo-distributed] add log_discarded_spans config for Tempo distributor to tempo-distrib… #3289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d490b55
add log_discarded_spans config for Tempo distributor to tempo-distrib…
dastrobu Aug 26, 2024
b9ab8da
Merge branch 'main' into tempo-distributed/log_discarded_spans
Sheikh-Abubaker Sep 15, 2024
d4509e8
Merge branch 'main' into tempo-distributed/log_discarded_spans
Sheikh-Abubaker Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/tempo-distributed/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-distributed
description: Grafana Tempo in MicroService mode
type: application
version: 1.18.0
version: 1.19.0
appVersion: 2.6.0
engine: gotpl
home: https://grafana.com/docs/tempo/latest/
Expand Down
5 changes: 4 additions & 1 deletion charts/tempo-distributed/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# tempo-distributed

![Version: 1.18.0](https://img.shields.io/badge/Version-1.18.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.6.0](https://img.shields.io/badge/AppVersion-2.6.0-informational?style=flat-square)
![Version: 1.19.0](https://img.shields.io/badge/Version-1.19.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.6.0](https://img.shields.io/badge/AppVersion-2.6.0-informational?style=flat-square)

Grafana Tempo in MicroService mode

Expand Down Expand Up @@ -322,6 +322,9 @@ The memcached default args are removed and should be provided manually. The sett
| distributor.autoscaling.targetCPUUtilizationPercentage | int | `60` | Target CPU utilisation percentage for the distributor |
| distributor.autoscaling.targetMemoryUtilizationPercentage | string | `nil` | Target memory utilisation percentage for the distributor |
| distributor.config.extend_writes | string | `nil` | Disables write extension with inactive ingesters |
| distributor.config.log_discarded_spans.enabled | bool | `false` | |
| distributor.config.log_discarded_spans.filter_by_status_error | bool | `false` | |
| distributor.config.log_discarded_spans.include_all_attributes | bool | `false` | |
| distributor.config.log_received_spans | object | `{"enabled":false,"filter_by_status_error":false,"include_all_attributes":false}` | Enable to log every received span to help debug ingestion or calculate span error distributions using the logs |
| distributor.config.log_received_traces | string | `nil` | WARNING: Deprecated. Use log_received_spans instead. |
| distributor.extraArgs | list | `[]` | Additional CLI args for the distributor |
Expand Down
10 changes: 10 additions & 0 deletions charts/tempo-distributed/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,10 @@ distributor:
enabled: false
include_all_attributes: false
filter_by_status_error: false
log_discarded_spans:
enabled: false
include_all_attributes: false
filter_by_status_error: false
# -- Disables write extension with inactive ingesters
extend_writes: null
# -- Adds the appProtocol field to the distributor service. This allows distributor to work with istio protocol selection.
Expand Down Expand Up @@ -1302,6 +1306,12 @@ config: |
kafka:
{{- toYaml .Values.traces.kafka | nindent 6 }}
{{- end }}
{{- if .Values.distributor.config.log_discarded_spans.enabled }}
log_discarded_spans:
enabled: {{ .Values.distributor.config.log_discarded_spans.enabled }}
include_all_attributes: {{ .Values.distributor.config.log_discarded_spans.include_all_attributes }}
filter_by_status_error: {{ .Values.distributor.config.log_discarded_spans.filter_by_status_error }}
{{- end }}
{{- if or .Values.distributor.config.log_received_traces .Values.distributor.config.log_received_spans.enabled }}
log_received_spans:
enabled: {{ or .Values.distributor.config.log_received_traces .Values.distributor.config.log_received_spans.enabled }}
Expand Down
Loading