[tempo-distributed] Add support to set specific Tempo gateway annotations #3692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garnaalkroket
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
Signed-off-by: Garnaalkroket <robindroeck@gmail.com>
Garnaalkroket
force-pushed
the
tempo-gateway-annotations
branch
from
df77751 to
a319551
Compare
zalegrala
approved these changes
May 2, 2025
Sheikh-Abubaker
approved these changes
May 2, 2025
|
Hey @Garnaalkroket Please address the failed CI check, before we could proceed to merge this, Thank you! |
Signed-off-by: Garnaalkroket <robindroeck@gmail.com>
Garnaalkroket
force-pushed
the
tempo-gateway-annotations
branch
from
d54c05a to
3247a08
Compare
|
I've updated the documentation and made a version bump, seeing as this is adding functionality that seems missed (as other deployments do have this feature) I opted for a patch version bump, please let me know if this should be a minor bump instead. |
@Garnaalkroket I believe you should go for a minor bump. |
Signed-off-by: Garnaalkroket <robindroeck@gmail.com>
Signed-off-by: Garnaalkroket <robindroeck@gmail.com>
|
I've changed the bump to a minor version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an annotations map (default empty) as part of the values for the gateway that allows for specifying annotations specific to the Tempo gateway deployment.
In order to comply with certain internal security standards it would be great to be able to specify annotations for the Tempo gateway deployment (now this is only possible for gateway pods). This functionality seems present for most other components (e.g.: distributor, compactor, querier) but seems left out for the gateway.