Do not panic if TZ parsing of iCal feed fails #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If parsing the time zone from the calendar feed fails, `loc` would be
`nil` and therefore the subsequent call `checkEvents()` would fail with
a panic, because the availability check requires the time.Location to be
not `nil`.
```
goroutine 1 [running]:
time.Time.In(...)
/usr/local/go/src/time/time.go:1167
github.com/grafana/escalation-scheduler/pkg/icassigner/calendar.(*icalAvailabilityChecker).isEventBlockingAvailability(0xc00015d588, {0x0?, 0xb484b9?, 0x0?}, {0xede56deb0?, 0x0?, 0x0?})
/src/pkg/icassigner/calendar/ical.go:61 +0x232
github.com/grafana/escalation-scheduler/pkg/icassigner/calendar.checkEvents({0xc003d28000, 0x1897, 0xc00015d8b8?}, {0xc0002fdeb0, 0xd}, {0x0?, 0x0?, 0x10cf060?}, 0x0, 0x13a52453c000)
/src/pkg/icassigner/calendar/ical.go:108 +0x2e5
github.com/grafana/escalation-scheduler/pkg/icassigner/calendar.CheckAvailability({0xc000337f80?, 0x10?}, {0xc0002fdeb0, 0xd}, {0x0?, 0x0?, 0x10cf060?}, 0x13a52453c000)
/src/pkg/icassigner/calendar/ical.go:162 +0x6dc
github.com/grafana/escalation-scheduler/pkg/icassigner.checkAvailability({{0xc0002fdeb0, 0xd}, {0xc000337f80, 0x79}, {0x0, 0x0}, {0xc0002fded0, 0xb}}, 0x13a52453c000)
/src/pkg/icassigner/action.go:181 +0x10d
github.com/grafana/escalation-scheduler/pkg/icassigner.(*Action).Run(0xc00015df00, {0xc45510, 0x11303c0}, 0xc0002aedc0, 0x1)
/src/pkg/icassigner/action.go:99 +0xe1a
main.main()
/src/cmd/ic-assignment/main.go:80 +0x4a5
```
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
replay
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If parsing the time zone from the calendar feed fails,
locwould beniland therefore the subsequent callcheckEvents()would fail with a panic, because the availability check requires the time.Location to be notnil.