-
Notifications
You must be signed in to change notification settings - Fork 242
Add deprecation on FID #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add deprecation on FID #2064
Conversation
It has been deprecated and removed already by Google, and we want to align with the new standards.
| --------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| browser_web_vital_cls | Measures the visual stability on a webpage by quantifying the amount of unexpected layout shift of visible page content. Refer to [Cumulative Layout Shift](https://web.dev/cls/) for more information. | | ||
| browser_web_vital_fid | Measures the responsiveness of a web page by quantifying the delay between a user’s first interaction, such as clicking a button, and the browser’s response. Refer to [First Input Delay](https://web.dev/fid/) for more information. | | ||
| ~~browser_web_vital_fid~~ | This is deprecated in favour of INP. ~~Measures the responsiveness of a web page by quantifying the delay between a user’s first interaction, such as clicking a button, and the browser’s response. Refer to [First Input Delay](https://web.dev/fid/) for more information.~~ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to remove FID? Or do you think people might still want to search for it?
If we choose to keep it, I think I'd tweak the text a little bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to eventually remove it. We need to leave this in until we have deprecated the measurement in k6. Once it is removed from k6, then I think we can remove it from the docs, otherwise there could be some confusion why k6 is measuring this, but no reference of it being in the docs.
How would you tweak the text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a link to the official web dev blog post that contains more details.
What?
It has been deprecated and removed already by Google, and we want to align with the new standards.
Result
Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.docs/sources/k6/v{most_recent_release}
folder of the documentation.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)
grafana/k6#5179