Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Aggregation for Counter, Gauge and Rate #1700

Closed
mstoykov opened this issue Oct 30, 2020 · 2 comments
Closed

Cloud Aggregation for Counter, Gauge and Rate #1700

mstoykov opened this issue Oct 30, 2020 · 2 comments
Assignees
Labels
enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature performance
Milestone

Comments

@mstoykov
Copy link
Contributor

This should not require any changes in the cloud backend and possibly can be the beginning of general in k6 aggregation as those types of metrics can be easily aggregated in k6 and don't require the backend knowing that they were aggregated.

I propose that this is done separately for each type in the order Counter, Rate, Gauge as that seems to be the most beneficial order. And only for the cloud for now as this is where we already have some of the needed code, and then it can be refactored to be more general.

This has the potential to take a lot of CPU though because of the current way tags .... are :( . Because of this, this will definetely require a lot of benchmarks and tests that we get the same end results.

Relevant previous PRs #1538

@mstoykov
Copy link
Contributor Author

Actually it seems Rate will be a problem :( as we are just sending a single value for it
https://github.com/loadimpact/k6/blob/d9bced340035e039407502773e664aebe9734815/stats/cloud/data.go#L90-L97
But in order to make this possible, we need to send how many trues and how many total we have (or some other variant of two values). This means that this will definetely need support on the cloud backend before it can be done.

This was also probably the one type that was probably even the best one to be done as all checks are actually rate, so this is a very common type of metric. I was previously under the impression that checks are Coutners ... which obviously isn't true ...

@na-- na-- added the evaluation needed proposal needs to be validated or tested before fully implementing it in k6 label Nov 13, 2020
@na-- na-- modified the milestones: v0.30.0, v0.31.0 Jan 13, 2021
@na-- na-- modified the milestones: v0.31.0, v0.32.0 Feb 24, 2021
@na-- na-- modified the milestones: v0.32.0, v0.33.0 Apr 14, 2021
@na-- na-- modified the milestones: v0.33.0, v0.34.0 Jun 16, 2021
@mstoykov mstoykov modified the milestones: v0.34.0, v0.35.0 Sep 1, 2021
@na-- na-- modified the milestones: v0.35.0, v0.36.0 Nov 2, 2021
@na-- na-- removed this from the v0.36.0 milestone Jan 18, 2022
@codebien codebien self-assigned this Apr 19, 2023
@codebien codebien added this to the v0.45.0 milestone Apr 26, 2023
@mstoykov
Copy link
Contributor Author

Closing this in favor of #2954

@mstoykov mstoykov closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature performance
Projects
None yet
Development

No branches or pull requests

3 participants