Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: New output v2 #3072

Merged
merged 2 commits into from
May 25, 2023
Merged

cloud: New output v2 #3072

merged 2 commits into from
May 25, 2023

Conversation

codebien
Copy link
Contributor

@codebien codebien commented May 16, 2023

It adds the foundation for a new cloud output versioned as v2.

It depends on the following PRs as a prerequisite:

@codebien codebien added this to the v0.45.0 milestone May 16, 2023
@codebien codebien self-assigned this May 16, 2023
@github-actions github-actions bot requested review from imiric and mstoykov May 16, 2023 12:10
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #3072 (7cf7dab) into master (06e1628) will increase coverage by 0.01%.
The diff coverage is 78.57%.

❗ Current head 7cf7dab differs from pull request most recent head 545dbe4. Consider uploading reports for the commit 545dbe4 to get more accurate results

@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
+ Coverage   75.29%   75.31%   +0.01%     
==========================================
  Files         232      233       +1     
  Lines       17593    17607      +14     
==========================================
+ Hits        13247    13260      +13     
- Misses       3494     3495       +1     
  Partials      852      852              
Flag Coverage Δ
ubuntu 75.31% <78.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/expv2/output.go 75.00% <75.00%> (ø)
output/cloud/output.go 76.87% <100.00%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

Base automatically changed from cloud/refactor/versioning to master May 16, 2023 14:51
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this doesn't have any of the logic, but just wanted to 👍 the general versioning approach

@imiric
Copy link
Contributor

imiric commented May 18, 2023

@codebien Is this PR ready for review? I've been ignoring it since it's marked as draft.

@codebien
Copy link
Contributor Author

codebien commented May 18, 2023

@imiric not really, the attempt here is to collect all the other PRs and then do a single merge to master. Of course, without really reviewing it because we reviewed the smaller PRs.

@mstoykov
Copy link
Contributor

If we are going to get this merged before all the other get merged, maybe drop the closes #number issue parts of the PR description?

@codebien codebien marked this pull request as ready for review May 25, 2023 14:55
@codebien codebien requested a review from mstoykov May 25, 2023 14:56
@codebien
Copy link
Contributor Author

Description updated

@codebien codebien merged commit 5738ce0 into master May 25, 2023
@codebien codebien deleted the add-cloud-expv2 branch May 25, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants