Merge browser in k6 #4056
Open
Merge browser in k6 #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [go.k6.io/k6](https://github.com/grafana/k6) from 0.53.1-0.20240925100229-86ab6e3ceee8 to 0.54.0. - [Release notes](https://github.com/grafana/k6/releases) - [Commits](https://github.com/grafana/k6/commits/v0.54.0) --- updated-dependencies: - dependency-name: go.k6.io/k6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This fix ensures that the taskqueue is closed when the iteration ends. If the taskqueue isn't closed when the iteration ends the k6 process will hang indefinitely. We used to rely on page.close, but now that the life cycle of the iteration is controlled by the VU we can safely rely on the VU context to ensure that the taskqueue is closed (if it isn't already closed).
`Description` should be `description`
This will allow us to write the test for all platforms that either work with Control or Meta when performing keyboard actions. E.g. Control+click on windows, and meta+click on mac to open a link in a new window.
The test now doesn't test with combo keys which doesn't work yet. Instead we're using dblClick.
The sobek code has been moved to the mapping layer, leaving the main business logic sobek free for keyboard.press.
The sobek code has been moved to the mapping layer, leaving the main business logic sobek free for keyboard.type.
This is to enable us to still work with the sync keyboard APIs with the Sobek changes removed from the business logic side of keyboard.
waitForSelector may result in a confusing error message:
selector did not resolve to any element
We're now explaining which selector didn't resolve to an element.
page.on only worked with console message, but we will need it to work for metric messages too. This change allows us to send any type and perform the type check in the handler.
It will need to be used in the page mapping.
Using switch to allow for multiple events.
NewBrowserContextOptions no longer makes sense. DefaultBrowserContextOptions also reads better when we look at the code. We can easily tell we're working with the default options, not just a new BrowserContextOptions value.
The main type here should BrowserContextOptions.
Bumps [go.k6.io/k6](https://github.com/grafana/k6) from 0.54.0 to 0.55.0. - [Release notes](https://github.com/grafana/k6/releases) - [Commits](v0.54.0...v0.55.0) --- updated-dependencies: - dependency-name: go.k6.io/k6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
The fix requires the reuse of waitFor, but it also requires the handle value to be returned. This refactors waitFor to return Handle.
The fix is in waitFor, and waitForSelector just needs to call waitFor to enable the fix. It basically will auto retry up to 20 times when certain errors are received from chrome. This can happens when the underlying DOM is changing due to a navigation, and the expected element that matches the selector is in the newly navigated DOM.
mstoykov
requested review from
inancgumus and
ankur22
and removed request for
a team
inancgumus
reviewed
Nov 13, 2024
|
the windows part is grafana/xk6-browser#571 ;) |
|
For the heads-up, there was one more update after this PR: |
|
I left the steps as I expect I/we are going to redo this PR once we fix even more stuff in browser. For example the lint errors seem like a good thing to be fixed before we merge it, and it will be way nicer to fix them in the browser repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move xk6-browser inside k6 codebase
Why?
Browser is no longer experimental and it makes more sense to have a single repository
List of commands I've ran:
git subtree add -P js/modules/k6/browser git@github.com:grafana/xk6-browser.git main- requires git-subtree - in practice can be done with a bunch of additional commands, just this is faser and easiergit rm -r CODE_OF_CONDUCT.md CODEOWNERS CONTRIBUTING.md docker-compose.yaml Dockerfile go.mod go.sum LICENSE Makefile README.md register.go SECURITY.md SUPPORT.md sync_register.go TROUBLESHOOTING.md release\ notes/ assets .golangci.yml .gitignore .github/git commit -m "browser: cleanup unnsecessary files" -nfind . -iname '*.go' | xargs sed -i -r 's|github.com/grafana/xk6-browser|go.k6.io/k6/js/modules/k6/browser|g'git commit -m "Move to using the in k6 browser code"TODO:
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)