-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge browser in k6 #4056
base: master
Are you sure you want to change the base?
Merge browser in k6 #4056
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4fca4e6 - Browse repository at this point
Copy the full SHA 4fca4e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d33f23b - Browse repository at this point
Copy the full SHA d33f23bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3acf0ff - Browse repository at this point
Copy the full SHA 3acf0ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61857d2 - Browse repository at this point
Copy the full SHA 61857d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38ac33f - Browse repository at this point
Copy the full SHA 38ac33fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40e3cea - Browse repository at this point
Copy the full SHA 40e3ceaView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf32e9 - Browse repository at this point
Copy the full SHA aaf32e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83496af - Browse repository at this point
Copy the full SHA 83496afView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6e8f78 - Browse repository at this point
Copy the full SHA a6e8f78View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc34feb - Browse repository at this point
Copy the full SHA cc34febView commit details
Commits on Oct 1, 2024
-
Bumps [go.k6.io/k6](https://github.com/grafana/k6) from 0.53.1-0.20240925100229-86ab6e3ceee8 to 0.54.0. - [Release notes](https://github.com/grafana/k6/releases) - [Commits](https://github.com/grafana/k6/commits/v0.54.0) --- updated-dependencies: - dependency-name: go.k6.io/k6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 577e169 - Browse repository at this point
Copy the full SHA 577e169View commit details -
Fix k6 process hang when using page.on
This fix ensures that the taskqueue is closed when the iteration ends. If the taskqueue isn't closed when the iteration ends the k6 process will hang indefinitely. We used to rely on page.close, but now that the life cycle of the iteration is controlled by the VU we can safely rely on the VU context to ensure that the taskqueue is closed (if it isn't already closed).
Configuration menu - View commit details
-
Copy full SHA for 8fce16a - Browse repository at this point
Copy the full SHA 8fce16aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c71bdb1 - Browse repository at this point
Copy the full SHA c71bdb1View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 61d4228 - Browse repository at this point
Copy the full SHA 61d4228View commit details
Commits on Oct 4, 2024
-
This will allow us to write the test for all platforms that either work with Control or Meta when performing keyboard actions. E.g. Control+click on windows, and meta+click on mac to open a link in a new window.
Configuration menu - View commit details
-
Copy full SHA for e429a04 - Browse repository at this point
Copy the full SHA e429a04View commit details -
Update test to work with dblClick
The test now doesn't test with combo keys which doesn't work yet. Instead we're using dblClick.
Configuration menu - View commit details
-
Copy full SHA for b04af2b - Browse repository at this point
Copy the full SHA b04af2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50be4e4 - Browse repository at this point
Copy the full SHA 50be4e4View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a3a36a4 - Browse repository at this point
Copy the full SHA a3a36a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6049bed - Browse repository at this point
Copy the full SHA 6049bedView commit details -
Remove sobek from keyboard.press
The sobek code has been moved to the mapping layer, leaving the main business logic sobek free for keyboard.press.
Configuration menu - View commit details
-
Copy full SHA for 8206006 - Browse repository at this point
Copy the full SHA 8206006View commit details -
Remove Sobek from keyboard.Press
The sobek code has been moved to the mapping layer, leaving the main business logic sobek free for keyboard.type.
Configuration menu - View commit details
-
Copy full SHA for 89df807 - Browse repository at this point
Copy the full SHA 89df807View commit details -
This is to enable us to still work with the sync keyboard APIs with the Sobek changes removed from the business logic side of keyboard.
Configuration menu - View commit details
-
Copy full SHA for e992fbd - Browse repository at this point
Copy the full SHA e992fbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09815eb - Browse repository at this point
Copy the full SHA 09815ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d3fb2c - Browse repository at this point
Copy the full SHA 6d3fb2cView commit details -
Enhance waitForSelector js error message
waitForSelector may result in a confusing error message: selector did not resolve to any element We're now explaining which selector didn't resolve to an element.
Configuration menu - View commit details
-
Copy full SHA for b364519 - Browse repository at this point
Copy the full SHA b364519View commit details -
Refactor page.on to work with any
page.on only worked with console message, but we will need it to work for metric messages too. This change allows us to send any type and perform the type check in the handler.
Configuration menu - View commit details
-
Copy full SHA for 0c207e1 - Browse repository at this point
Copy the full SHA 0c207e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4ce0b8 - Browse repository at this point
Copy the full SHA c4ce0b8View commit details -
Refactor event so that it is exported
It will need to be used in the page mapping.
Configuration menu - View commit details
-
Copy full SHA for 370c156 - Browse repository at this point
Copy the full SHA 370c156View commit details -
Refactor page mapping to work with switch
Using switch to allow for multiple events.
Configuration menu - View commit details
-
Copy full SHA for 1c30981 - Browse repository at this point
Copy the full SHA 1c30981View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bb8a8f - Browse repository at this point
Copy the full SHA 2bb8a8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe9e211 - Browse repository at this point
Copy the full SHA fe9e211View commit details -
This is what the user will receive in the page.on callback for the metric event. It's just a skeleton for now.
Configuration menu - View commit details
-
Copy full SHA for 5892800 - Browse repository at this point
Copy the full SHA 5892800View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60f7817 - Browse repository at this point
Copy the full SHA 60f7817View commit details -
We can now map and return the metric back to the user so that they can work with it in the handle.
Configuration menu - View commit details
-
Copy full SHA for f186a27 - Browse repository at this point
Copy the full SHA f186a27View commit details -
Add a grouping func to sobek runtime
We want to use the regex engine in the sobek runtime which should be the same or similar to other JS regex engines. This function will be used to work with the user defined regex to group metrics with url tags.
Configuration menu - View commit details
-
Copy full SHA for fcd1ea3 - Browse repository at this point
Copy the full SHA fcd1ea3View commit details -
The callback is what will be used to work with the sobek runtime. We want to avoid using sobek outside the mapping layer.
Configuration menu - View commit details
-
Copy full SHA for 4bc8de3 - Browse repository at this point
Copy the full SHA 4bc8de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e012605 - Browse repository at this point
Copy the full SHA e012605View commit details -
Add synchronization and name propagation
The name needs to be sent back to the caller that needs it. It is done via a channel. When running things on the taskqueue, they are done async. We need to make this process synchronous. We're relying on the nameCh (the same channel that the name is sent to the caller on) to notify the called when the handler has complete.
Configuration menu - View commit details
-
Copy full SHA for 49cd0ce - Browse repository at this point
Copy the full SHA 49cd0ceView commit details -
Add function to call the handlers
This function will call the handlers one by one, allowing each handler to check the url matches and return the name. Each handler will overwrite the name if multiple handlers match with the given url. This function needs to wait for the handler to complete before proceeding to the next handler.
Configuration menu - View commit details
-
Copy full SHA for d3110fe - Browse repository at this point
Copy the full SHA d3110feView commit details -
Configuration menu - View commit details
-
Copy full SHA for d667f02 - Browse repository at this point
Copy the full SHA d667f02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b6cf06 - Browse repository at this point
Copy the full SHA 9b6cf06View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3c14f5 - Browse repository at this point
Copy the full SHA b3c14f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 101da13 - Browse repository at this point
Copy the full SHA 101da13View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed26cd9 - Browse repository at this point
Copy the full SHA ed26cd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa20705 - Browse repository at this point
Copy the full SHA fa20705View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51197b4 - Browse repository at this point
Copy the full SHA 51197b4View commit details -
Update URL and use any instead of interface{}
Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 745a551 - Browse repository at this point
Copy the full SHA 745a551View commit details -
Refactor to use atomic in TestPageOnMetric
This makes working with an atomic int more maintainable.
Configuration menu - View commit details
-
Copy full SHA for 9974a5b - Browse repository at this point
Copy the full SHA 9974a5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8c2638 - Browse repository at this point
Copy the full SHA d8c2638View commit details -
Configuration menu - View commit details
-
Copy full SHA for 431f59e - Browse repository at this point
Copy the full SHA 431f59eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 947c4e1 - Browse repository at this point
Copy the full SHA 947c4e1View commit details -
Refactor how the name is returned back to caller
Instead of working with goroutines and channels to propagate the name back from GroupURLTag, a name field is updated in ExportedMetric. The call to the taskqueue is synchronised so when the handler is called we can safely wait for it to complete instead of relying on channels and contexts to wait for it to complete.
Configuration menu - View commit details
-
Copy full SHA for ec7856f - Browse repository at this point
Copy the full SHA ec7856fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 042527b - Browse repository at this point
Copy the full SHA 042527bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92bf084 - Browse repository at this point
Copy the full SHA 92bf084View commit details -
Configuration menu - View commit details
-
Copy full SHA for 001e8c1 - Browse repository at this point
Copy the full SHA 001e8c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20502bd - Browse repository at this point
Copy the full SHA 20502bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a25939 - Browse repository at this point
Copy the full SHA 5a25939View commit details -
This better represents what is happening. When a match is found, the metric is tagged. It is not grouping anything, the grouping is a wanted side effect.
Configuration menu - View commit details
-
Copy full SHA for 6b91b79 - Browse repository at this point
Copy the full SHA 6b91b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e9eff5 - Browse repository at this point
Copy the full SHA 2e9eff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d444108 - Browse repository at this point
Copy the full SHA d444108View commit details -
Configuration menu - View commit details
-
Copy full SHA for 180f911 - Browse repository at this point
Copy the full SHA 180f911View commit details -
Refactor MetricEvent out of loop
We're now only creating a single MetricEvent for all handlers.
Configuration menu - View commit details
-
Copy full SHA for 536ebee - Browse repository at this point
Copy the full SHA 536ebeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba709b - Browse repository at this point
Copy the full SHA 0ba709bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13abc6c - Browse repository at this point
Copy the full SHA 13abc6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ccf482 - Browse repository at this point
Copy the full SHA 2ccf482View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70ccdea - Browse repository at this point
Copy the full SHA 70ccdeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe0f161 - Browse repository at this point
Copy the full SHA fe0f161View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fd0811 - Browse repository at this point
Copy the full SHA 6fd0811View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55e61a3 - Browse repository at this point
Copy the full SHA 55e61a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67214db - Browse repository at this point
Copy the full SHA 67214dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ff7789 - Browse repository at this point
Copy the full SHA 1ff7789View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cbe1b0 - Browse repository at this point
Copy the full SHA 7cbe1b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94e6971 - Browse repository at this point
Copy the full SHA 94e6971View commit details -
Rename the JS fields back to url and name
Leaving the names as in the go code.
Configuration menu - View commit details
-
Copy full SHA for f6dd73c - Browse repository at this point
Copy the full SHA f6dd73cView commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 40f60ca - Browse repository at this point
Copy the full SHA 40f60caView commit details -
Update PostData to work with PostDataEntries
From some of my testing it would seem that PostDataEntries doesn't contain more than a single entry. I've tried with various types of request data such as: - application/json - multipart/related - application/x-www-form-urlencoded - application/form-data and so far none of them exhibits a change in behaviour where more than one element in PostDataEntries is occupied. We can work with the 0th entry of PostDataEntries for now until a need arises for needing to work with the rest of the slice (i.e. we have a better idea of when that happens).
Configuration menu - View commit details
-
Copy full SHA for 4e1fba5 - Browse repository at this point
Copy the full SHA 4e1fba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed4b00 - Browse repository at this point
Copy the full SHA 7ed4b00View commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a4e6e9 - Browse repository at this point
Copy the full SHA 7a4e6e9View commit details
Commits on Oct 10, 2024
-
Fix metric event tag method name
Mapped methods are lowercase so that we can test them. They're also used in JavaScript like so.
Configuration menu - View commit details
-
Copy full SHA for a30af07 - Browse repository at this point
Copy the full SHA a30af07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5257878 - Browse repository at this point
Copy the full SHA 5257878View commit details -
So that we can use it the mapping test.
Configuration menu - View commit details
-
Copy full SHA for a342f7d - Browse repository at this point
Copy the full SHA a342f7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca24744 - Browse repository at this point
Copy the full SHA ca24744View commit details -
Configuration menu - View commit details
-
Copy full SHA for 667efa0 - Browse repository at this point
Copy the full SHA 667efa0View commit details -
JavaScript functions are conventionally lowercase, and since we changed Tag to tag from the Go side, we should also rename this script.
Configuration menu - View commit details
-
Copy full SHA for 8bf713f - Browse repository at this point
Copy the full SHA 8bf713fView commit details -
Move k6BrowserRegEx checker to page on mapping
So that we can get rid of the non-conforming metric mapper. This way, we don't have to deal with error handling in other mappers in the test. This provides a uniform way. Also, this is a prior step for the generalization of the page on API.
Configuration menu - View commit details
-
Copy full SHA for ab1c556 - Browse repository at this point
Copy the full SHA ab1c556View commit details -
Improve page.on metric namings
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for ebb1391 - Browse repository at this point
Copy the full SHA ebb1391View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9d9252 - Browse repository at this point
Copy the full SHA f9d9252View commit details -
This type contains `page.on` events. Rather than using `any` to describe any event, we use a named type to make it explicit what we're using. Also, this will eliminate type assertions from the code, making it type safe.
Configuration menu - View commit details
-
Copy full SHA for d6fefd3 - Browse repository at this point
Copy the full SHA d6fefd3View commit details -
We now use a type-safe way to describe and pass events throughout the code. We get rid of type assertions. This provides a way to extend the type later on with new page on event types.
Configuration menu - View commit details
-
Copy full SHA for ad484b0 - Browse repository at this point
Copy the full SHA ad484b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57e1db0 - Browse repository at this point
Copy the full SHA 57e1db0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b680e2c - Browse repository at this point
Copy the full SHA b680e2cView commit details -
Add PageOnEventName for type safety
This will be used by all page on event names. With this, we won't require whether a provided event is valid. The compiler will enforce it for us.
Configuration menu - View commit details
-
Copy full SHA for 206c2a8 - Browse repository at this point
Copy the full SHA 206c2a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0042e6 - Browse repository at this point
Copy the full SHA c0042e6View commit details -
Remove page on event name check
This is safe to do so as we will no longer pass a rogue string to this method. Only the page on event names can be passed to this function. Unless, of course, somebody converts a string with an incorrect name to PageOnEventName to call this function. This will easily be catched in reviews, and nobody would do such a thing. We follow the Go idiom of being pragmatic instead of being highly defensive. Also, this method is used by the mapping layer, and there is already an event name check.
Configuration menu - View commit details
-
Copy full SHA for dab04d6 - Browse repository at this point
Copy the full SHA dab04d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16a650a - Browse repository at this point
Copy the full SHA 16a650aView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 68cff64 - Browse repository at this point
Copy the full SHA 68cff64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75647e9 - Browse repository at this point
Copy the full SHA 75647e9View commit details -
Move pageOn mapping to a function
The page on mapping is large and hard to work with while making the changes. Putting it into a new function is subjetively more readable and makes it easier to work with the function.
Configuration menu - View commit details
-
Copy full SHA for 6ddebf9 - Browse repository at this point
Copy the full SHA 6ddebf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5489038 - Browse repository at this point
Copy the full SHA 5489038View commit details -
Configuration menu - View commit details
-
Copy full SHA for cafed06 - Browse repository at this point
Copy the full SHA cafed06View commit details -
Rename runInTaskQueue to mapHandler
No need to specify the implementation details that can change. Our main goal here is to map the page on event handler to sobek.
Configuration menu - View commit details
-
Copy full SHA for f2528ab - Browse repository at this point
Copy the full SHA f2528abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a89562 - Browse repository at this point
Copy the full SHA 5a89562View commit details -
Configuration menu - View commit details
-
Copy full SHA for be5f3ea - Browse repository at this point
Copy the full SHA be5f3eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5d4c63 - Browse repository at this point
Copy the full SHA b5d4c63View commit details -
Refactor mapConsoleMessage to PageOnEvent
This is to uniform all the page on event mappers.
Configuration menu - View commit details
-
Copy full SHA for 24e2a25 - Browse repository at this point
Copy the full SHA 24e2a25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8357a7d - Browse repository at this point
Copy the full SHA 8357a7dView commit details -
Refactor mapConsoleMessage out of sobek
No need to wrap the return values into sobek ones.
Configuration menu - View commit details
-
Copy full SHA for f08046b - Browse repository at this point
Copy the full SHA f08046bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a786310 - Browse repository at this point
Copy the full SHA a786310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f99d54 - Browse repository at this point
Copy the full SHA 7f99d54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8833a2f - Browse repository at this point
Copy the full SHA 8833a2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 705086c - Browse repository at this point
Copy the full SHA 705086cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dee7bc - Browse repository at this point
Copy the full SHA 0dee7bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 305ec95 - Browse repository at this point
Copy the full SHA 305ec95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91ff150 - Browse repository at this point
Copy the full SHA 91ff150View commit details -
This will run any page on event mapper.
Configuration menu - View commit details
-
Copy full SHA for 4ffe550 - Browse repository at this point
Copy the full SHA 4ffe550View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46ccf03 - Browse repository at this point
Copy the full SHA 46ccf03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17092c4 - Browse repository at this point
Copy the full SHA 17092c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f006807 - Browse repository at this point
Copy the full SHA f006807View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bafc79 - Browse repository at this point
Copy the full SHA 4bafc79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76b6cda - Browse repository at this point
Copy the full SHA 76b6cdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 366f14d - Browse repository at this point
Copy the full SHA 366f14dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c060516 - Browse repository at this point
Copy the full SHA c060516View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0099139 - Browse repository at this point
Copy the full SHA 0099139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ad8ade - Browse repository at this point
Copy the full SHA 7ad8adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06a411f - Browse repository at this point
Copy the full SHA 06a411fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d254ab - Browse repository at this point
Copy the full SHA 4d254abView commit details -
Configuration menu - View commit details
-
Copy full SHA for a34d1a2 - Browse repository at this point
Copy the full SHA a34d1a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92bf427 - Browse repository at this point
Copy the full SHA 92bf427View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee9039 - Browse repository at this point
Copy the full SHA 3ee9039View commit details -
Configuration menu - View commit details
-
Copy full SHA for 725f825 - Browse repository at this point
Copy the full SHA 725f825View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5daf078 - Browse repository at this point
Copy the full SHA 5daf078View commit details -
Configuration menu - View commit details
-
Copy full SHA for c98da11 - Browse repository at this point
Copy the full SHA c98da11View commit details -
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for 096afd8 - Browse repository at this point
Copy the full SHA 096afd8View commit details -
Use pattern directly in k6BrowserCheckRegEx
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
Configuration menu - View commit details
-
Copy full SHA for f757283 - Browse repository at this point
Copy the full SHA f757283View commit details -
Configuration menu - View commit details
-
Copy full SHA for 235fc72 - Browse repository at this point
Copy the full SHA 235fc72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 427cbbf - Browse repository at this point
Copy the full SHA 427cbbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6b5921 - Browse repository at this point
Copy the full SHA b6b5921View commit details -
We need to read lock first to prevent race conditions while looping over the handlers. Then, we allow each handler to add a nested handler by read unlocking it.
Configuration menu - View commit details
-
Copy full SHA for 8d83a89 - Browse repository at this point
Copy the full SHA 8d83a89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 346cf13 - Browse repository at this point
Copy the full SHA 346cf13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bdb2de - Browse repository at this point
Copy the full SHA 5bdb2deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cff454 - Browse repository at this point
Copy the full SHA 2cff454View commit details
Commits on Oct 17, 2024
-
When we read off the read queue, we alias the slice. What has been forgotten though is to remove the reference to the entry in the slice after it has been read. This fixes that by overwriting the entry with a new Event. This now allows the GC to pick up the buffered data that the event was holding onto.
Configuration menu - View commit details
-
Copy full SHA for 58f9bc3 - Browse repository at this point
Copy the full SHA 58f9bc3View commit details -
Update the name field on page.on metric API
This moves the name field into the level above. This makes the API less confusing and allows us to extend the API to add other fields apart from just urls. We can now read the API as: * metric.tag * with name * when urls match
Configuration menu - View commit details
-
Copy full SHA for e0be11d - Browse repository at this point
Copy the full SHA e0be11dView commit details -
This is a better representation of what we're doing with the fields. They are being used to find matches in the existing metric tags that are about to be emitted.
Configuration menu - View commit details
-
Copy full SHA for 64bd4cd - Browse repository at this point
Copy the full SHA 64bd4cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e37210 - Browse repository at this point
Copy the full SHA 5e37210View commit details -
Configuration menu - View commit details
-
Copy full SHA for 280656f - Browse repository at this point
Copy the full SHA 280656fView commit details -
Move the name error check outside for loop
Since the name field is now one level above, it doesn't need to be in the for loop.
Configuration menu - View commit details
-
Copy full SHA for 8eb5683 - Browse repository at this point
Copy the full SHA 8eb5683View commit details -
Renaming userProvidedTagName to userProvidedURLTagName since it's important to know that the name tag will be used on the url tag.
Configuration menu - View commit details
-
Copy full SHA for bb53cc6 - Browse repository at this point
Copy the full SHA bb53cc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2700524 - Browse repository at this point
Copy the full SHA 2700524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07055b8 - Browse repository at this point
Copy the full SHA 07055b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a509cf1 - Browse repository at this point
Copy the full SHA a509cf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d14812a - Browse repository at this point
Copy the full SHA d14812aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 844224c - Browse repository at this point
Copy the full SHA 844224cView commit details -
Compares the method from the user vs what the metric was tagged with.
Configuration menu - View commit details
-
Copy full SHA for 9b2c00e - Browse repository at this point
Copy the full SHA 9b2c00eView commit details -
Configuration menu - View commit details
-
Copy full SHA for def41a9 - Browse repository at this point
Copy the full SHA def41a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa5a9c4 - Browse repository at this point
Copy the full SHA aa5a9c4View commit details -
Add a test to showcase incorrect method
When the incorrect method is used in a Match, the expectation is for the test to continue but not match and therefore the urls aren't tagged with the name and so aren't grouped.
Configuration menu - View commit details
-
Copy full SHA for b90b48f - Browse repository at this point
Copy the full SHA b90b48fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59138b2 - Browse repository at this point
Copy the full SHA 59138b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4802639 - Browse repository at this point
Copy the full SHA 4802639View commit details -
Configuration menu - View commit details
-
Copy full SHA for aedd78e - Browse repository at this point
Copy the full SHA aedd78eView commit details
Commits on Oct 18, 2024
-
If the context is done before all the tasks are read from the queue, the remaining tasks on the queue will not be read and so the done channel will not be closed causing the goroutine to wait forever. This is solved by adding a context.Done() check so that when the context is closed we can carry on with shutting down of the iteration.
Configuration menu - View commit details
-
Copy full SHA for 67d6dc8 - Browse repository at this point
Copy the full SHA 67d6dc8View commit details
Commits on Oct 25, 2024
-
Add context done case to waitForEvent
If the context is done before all the tasks are read from the queue, the remaining tasks on the queue will not be read and so the done channel will not be closed causing the goroutine to wait forever. This is solved by adding a context.Done() check so that when the context is closed we can carry on with shutting down of the iteration.
Configuration menu - View commit details
-
Copy full SHA for 135e886 - Browse repository at this point
Copy the full SHA 135e886View commit details -
This will make it simpler to read and maintain the page.on handler code.
Configuration menu - View commit details
-
Copy full SHA for 90b8cf7 - Browse repository at this point
Copy the full SHA 90b8cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f332592 - Browse repository at this point
Copy the full SHA f332592View commit details -
Update page.on handler to return error
When the context is closed, we should return an error to notify the user that not all handlers completed execution.
Configuration menu - View commit details
-
Copy full SHA for dce4487 - Browse repository at this point
Copy the full SHA dce4487View commit details -
Add error handling on page.on(metric) handler
The most important thing to do is to handle the error and ensure that the page.on metric returns false so that the metric tag isn't update. This is being defensive, since the context has already closed and the metric emitter will not emit a metric when the context has closed. We're logging a debug log here since this information will not benefit the end user and when this error occurs they can't action on it. It could be useful for debugging though.
Configuration menu - View commit details
-
Copy full SHA for 2a04643 - Browse repository at this point
Copy the full SHA 2a04643View commit details -
Add err handling to page.on(console)
Mainly useful for debugging purposes, but otherwise this isn't really needed except to ensure we exit asap from the for loop when the context has ended and therefore the iteration has ended.
Configuration menu - View commit details
-
Copy full SHA for 18cbe37 - Browse repository at this point
Copy the full SHA 18cbe37View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0fa724 - Browse repository at this point
Copy the full SHA a0fa724View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37ff724 - Browse repository at this point
Copy the full SHA 37ff724View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd99620 - Browse repository at this point
Copy the full SHA bd99620View commit details -
Add BrowserContext.DownloadsPath field
NewBrowserContext will set this field to the download directory. Then, we can get it from tests.
Configuration menu - View commit details
-
Copy full SHA for b6fb3b0 - Browse repository at this point
Copy the full SHA b6fb3b0View commit details -
This represents the directory where we will store artifacts like downloaded files.
Configuration menu - View commit details
-
Copy full SHA for 565f70a - Browse repository at this point
Copy the full SHA 565f70aView commit details -
Add BrowserContext.setDownloadsPath
This will be called from NewBrowserContext and the tests. We use the given path. Otherwise, we're creating a temporary directory with the artifactsDirectory prefix.
Configuration menu - View commit details
-
Copy full SHA for 0b2e27e - Browse repository at this point
Copy the full SHA 0b2e27eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4001f38 - Browse repository at this point
Copy the full SHA 4001f38View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac0281b - Browse repository at this point
Copy the full SHA ac0281bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b86a59f - Browse repository at this point
Copy the full SHA b86a59fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 943c568 - Browse repository at this point
Copy the full SHA 943c568View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56449e9 - Browse repository at this point
Copy the full SHA 56449e9View commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a979027 - Browse repository at this point
Copy the full SHA a979027View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1d4bc0 - Browse repository at this point
Copy the full SHA a1d4bc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f77f185 - Browse repository at this point
Copy the full SHA f77f185View commit details -
Configuration menu - View commit details
-
Copy full SHA for a94dd45 - Browse repository at this point
Copy the full SHA a94dd45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53db24d - Browse repository at this point
Copy the full SHA 53db24dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44fa0c0 - Browse repository at this point
Copy the full SHA 44fa0c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 173e100 - Browse repository at this point
Copy the full SHA 173e100View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2303d9c - Browse repository at this point
Copy the full SHA 2303d9cView commit details -
Desobekify BrowserContextOptionParsing
Moves the Sobek-dependent option parsing part out of the business logic. Once we finish, we can entirely remove the Sobek dependency.
Configuration menu - View commit details
-
Copy full SHA for 946e4cb - Browse repository at this point
Copy the full SHA 946e4cbView commit details
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4773396 - Browse repository at this point
Copy the full SHA 4773396View commit details -
Refactor GrantPermissionOptions parsing to mapping
- Turns GrantPermissionsOptions to a value type from a pointer as this type is not need to be used to be mutated. - Moves Sobek transformation to the mapping layer.
Configuration menu - View commit details
-
Copy full SHA for ea41b9e - Browse repository at this point
Copy the full SHA ea41b9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe02411 - Browse repository at this point
Copy the full SHA fe02411View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7bd994 - Browse repository at this point
Copy the full SHA d7bd994View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25b0fba - Browse repository at this point
Copy the full SHA 25b0fbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fddcd9 - Browse repository at this point
Copy the full SHA 9fddcd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d39abde - Browse repository at this point
Copy the full SHA d39abdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5836d19 - Browse repository at this point
Copy the full SHA 5836d19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4634741 - Browse repository at this point
Copy the full SHA 4634741View commit details -
Move SetGeolocation validation into business logic
Separating the transformation of a Sobek value from the validation of it.
Configuration menu - View commit details
-
Copy full SHA for 17dfb7f - Browse repository at this point
Copy the full SHA 17dfb7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 879dbbb - Browse repository at this point
Copy the full SHA 879dbbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed1488e - Browse repository at this point
Copy the full SHA ed1488eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a7b64b - Browse repository at this point
Copy the full SHA 2a7b64bView commit details
Commits on Nov 7, 2024
-
Define codeowners for this project to automate the process of assigning code reviewers.
Configuration menu - View commit details
-
Copy full SHA for c4b86d3 - Browse repository at this point
Copy the full SHA c4b86d3View commit details -
* Refer to the public k6 roadmap in the README * Delete the outdated roadmap * Update release badge URL
Configuration menu - View commit details
-
Copy full SHA for 7a8ee0c - Browse repository at this point
Copy the full SHA 7a8ee0cView commit details -
Fix Sobek.Object.Get(key) *[]any issue
This was causing the CI tests to fail after an update made to Sobek.
Configuration menu - View commit details
-
Copy full SHA for 740dac8 - Browse repository at this point
Copy the full SHA 740dac8View commit details -
This only fixes the panic, but not the underlying error with WaitForEvent. There is clearly an issue with WaitForEvent as we can also see in #1506.
Configuration menu - View commit details
-
Copy full SHA for 151b982 - Browse repository at this point
Copy the full SHA 151b982View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3479f77 - Browse repository at this point
Copy the full SHA 3479f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 045a6ee - Browse repository at this point
Copy the full SHA 045a6eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3c6f49 - Browse repository at this point
Copy the full SHA a3c6f49View commit details -
Configuration menu - View commit details
-
Copy full SHA for e85e2a8 - Browse repository at this point
Copy the full SHA e85e2a8View commit details -
Use Credentials as a value type
No need for this type to be a pointer.
Configuration menu - View commit details
-
Copy full SHA for 51fe2db - Browse repository at this point
Copy the full SHA 51fe2dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d745970 - Browse repository at this point
Copy the full SHA d745970View commit details -
Configuration menu - View commit details
-
Copy full SHA for b58904b - Browse repository at this point
Copy the full SHA b58904bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d4690f - Browse repository at this point
Copy the full SHA 3d4690fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4edff5 - Browse repository at this point
Copy the full SHA b4edff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 598e786 - Browse repository at this point
Copy the full SHA 598e786View commit details -
Configuration menu - View commit details
-
Copy full SHA for 306c535 - Browse repository at this point
Copy the full SHA 306c535View commit details -
Rename calculateInset to recalculateInset
This pattern we use is similar to https://pkg.go.dev/time#Time.Add. Instead of using a pointer and updating a simple value in place, we return a new one.
Configuration menu - View commit details
-
Copy full SHA for a987705 - Browse repository at this point
Copy the full SHA a987705View commit details -
Configuration menu - View commit details
-
Copy full SHA for e990565 - Browse repository at this point
Copy the full SHA e990565View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3726b49 - Browse repository at this point
Copy the full SHA 3726b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74057e0 - Browse repository at this point
Copy the full SHA 74057e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c9f9c1 - Browse repository at this point
Copy the full SHA 7c9f9c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5100b4a - Browse repository at this point
Copy the full SHA 5100b4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b675030 - Browse repository at this point
Copy the full SHA b675030View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0a0e05 - Browse repository at this point
Copy the full SHA a0a0e05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30850f2 - Browse repository at this point
Copy the full SHA 30850f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b09c5f - Browse repository at this point
Copy the full SHA 4b09c5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c11fbad - Browse repository at this point
Copy the full SHA c11fbadView commit details -
Configuration menu - View commit details
-
Copy full SHA for be2a913 - Browse repository at this point
Copy the full SHA be2a913View commit details -
Configuration menu - View commit details
-
Copy full SHA for daace5f - Browse repository at this point
Copy the full SHA daace5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 147ec11 - Browse repository at this point
Copy the full SHA 147ec11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7abe780 - Browse repository at this point
Copy the full SHA 7abe780View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ddf95 - Browse repository at this point
Copy the full SHA 25ddf95View commit details -
Configuration menu - View commit details
-
Copy full SHA for f793eb6 - Browse repository at this point
Copy the full SHA f793eb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2448493 - Browse repository at this point
Copy the full SHA 2448493View commit details -
Configuration menu - View commit details
-
Copy full SHA for 287d7a5 - Browse repository at this point
Copy the full SHA 287d7a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbd050f - Browse repository at this point
Copy the full SHA dbd050fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7390743 - Browse repository at this point
Copy the full SHA 7390743View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b3df76 - Browse repository at this point
Copy the full SHA 2b3df76View commit details -
Configuration menu - View commit details
-
Copy full SHA for a87da04 - Browse repository at this point
Copy the full SHA a87da04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26a9eff - Browse repository at this point
Copy the full SHA 26a9effView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee71c5 - Browse repository at this point
Copy the full SHA 7ee71c5View commit details -
Rename to DefaultBrowserContextOptions
NewBrowserContextOptions no longer makes sense. DefaultBrowserContextOptions also reads better when we look at the code. We can easily tell we're working with the default options, not just a new BrowserContextOptions value.
Configuration menu - View commit details
-
Copy full SHA for 6e8c206 - Browse repository at this point
Copy the full SHA 6e8c206View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d6121e - Browse repository at this point
Copy the full SHA 5d6121eView commit details -
The main type here should BrowserContextOptions.
Configuration menu - View commit details
-
Copy full SHA for a5ba0c4 - Browse repository at this point
Copy the full SHA a5ba0c4View commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 946cb18 - Browse repository at this point
Copy the full SHA 946cb18View commit details
Commits on Nov 12, 2024
-
Bump (deps): Bump go.k6.io/k6 from 0.54.0 to 0.55.0
Bumps [go.k6.io/k6](https://github.com/grafana/k6) from 0.54.0 to 0.55.0. - [Release notes](https://github.com/grafana/k6/releases) - [Commits](v0.54.0...v0.55.0) --- updated-dependencies: - dependency-name: go.k6.io/k6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for e75e6f3 - Browse repository at this point
Copy the full SHA e75e6f3View commit details -
Refactor waitFor so that it returns a handle
The fix requires the reuse of waitFor, but it also requires the handle value to be returned. This refactors waitFor to return Handle.
Configuration menu - View commit details
-
Copy full SHA for f381bee - Browse repository at this point
Copy the full SHA f381beeView commit details -
Fix waitForSelector by calling waitFor
The fix is in waitFor, and waitForSelector just needs to call waitFor to enable the fix. It basically will auto retry up to 20 times when certain errors are received from chrome. This can happens when the underlying DOM is changing due to a navigation, and the expected element that matches the selector is in the newly navigated DOM.
Configuration menu - View commit details
-
Copy full SHA for 1974b8a - Browse repository at this point
Copy the full SHA 1974b8aView commit details
Commits on Nov 13, 2024
-
Add 'js/modules/k6/browser/' from commit '1974b8a50abace6dabefd38b363…
Configuration menu - View commit details
-
Copy full SHA for 3c906c4 - Browse repository at this point
Copy the full SHA 3c906c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05fb20e - Browse repository at this point
Copy the full SHA 05fb20eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b587dd - Browse repository at this point
Copy the full SHA 2b587ddView commit details