Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the registry for (sub-)metric validation and move data crunching out of the Engine #2426

Merged
merged 11 commits into from
Mar 29, 2022
Merged

Use the registry for (sub-)metric validation and move data crunching out of the Engine #2426

merged 11 commits into from
Mar 29, 2022

Commits on Mar 29, 2022

  1. Move Output management out of the Engine

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    4f4e384 View commit details
    Browse the repository at this point in the history

  2. Move the metrics package out of lib/

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    e2441d7 View commit details
    Browse the repository at this point in the history

  3. Refactor the Engine to actually use the metrics registry 

    This is a prerequisite for solving other issues like always evaluating thresholds correctly, and as a side-benefit, it also allows us to validate them in the init context, before the test has started.
    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    9b3968e View commit details
    Browse the repository at this point in the history

  4. Fix the bug of thresholds not working for unused metrics

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    f44ecad View commit details
    Browse the repository at this point in the history

  5. Fix submetric matching bug when nonexistent keys are specified

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    2115bcb View commit details
    Browse the repository at this point in the history

  6. Pass BuiltinMetrics via ExecState, emit vus and vus_max by ExecScheduler 

    This allows us to slowly deconstruct and split apart the Engine. It also clears the way for us to have test suites, where every test has a separate pool of VUs and its own ExecutionScheduler.
    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    ed65ad1 View commit details
    Browse the repository at this point in the history

  7. Add an integration test for custom metrics and thresholds

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    52262f0 View commit details
    Browse the repository at this point in the history

  8. Move the Engine data crunching logic in a new component under metrics/

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    ce2f4b2 View commit details
    Browse the repository at this point in the history

  9. Rename signal handlers to be clearer

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    9d58579 View commit details
    Browse the repository at this point in the history

  10. Make code more readable based on PR reviews

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    25144a6 View commit details
    Browse the repository at this point in the history

  11. Make the REST API tests less flaky

    @na--
    na-- committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    8276246 View commit details
    Browse the repository at this point in the history