Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/cloud: Drop version 1 #3092

Merged
merged 5 commits into from
Feb 12, 2024
Merged

output/cloud: Drop version 1 #3092

merged 5 commits into from
Feb 12, 2024

Conversation

codebien
Copy link
Contributor

@codebien codebien commented May 24, 2023

What

It is the final step of the migration process between cloudv1 and v2.

@codebien codebien self-assigned this May 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b478bb) 72.96% compared to head (de5fcd9) 73.41%.

❗ Current head de5fcd9 differs from pull request most recent head d11a4f1. Consider uploading reports for the commit d11a4f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
+ Coverage   72.96%   73.41%   +0.44%     
==========================================
  Files         280      276       -4     
  Lines       20949    20047     -902     
==========================================
- Hits        15285    14717     -568     
+ Misses       4693     4388     -305     
+ Partials      971      942      -29     
Flag Coverage Δ
macos 73.33% <100.00%> (?)
ubuntu 73.35% <100.00%> (+0.44%) ⬆️
windows 73.26% <100.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien added this to the v0.46.0 milestone May 25, 2023
@codebien codebien force-pushed the cloud-v2-optimized-sinks branch 3 times, most recently from eb0c005 to b50020a Compare May 30, 2023 14:31
@codebien codebien changed the base branch from cloud-v2-optimized-sinks to cloud-v2-bucket-unix-time May 30, 2023 15:49
Base automatically changed from cloud-v2-bucket-unix-time to master May 31, 2023 09:26
@codebien codebien modified the milestones: v0.46.0, v0.48.0 Jun 1, 2023
@codebien codebien mentioned this pull request Jun 12, 2023
@codebien codebien force-pushed the attempt-drop-cloudv1 branch 4 times, most recently from 576031b to c45dd5d Compare July 13, 2023 05:44
@codebien codebien marked this pull request as ready for review October 12, 2023 12:54
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run cloud integration tests first

@codebien codebien marked this pull request as draft October 12, 2023 13:16
@codebien codebien modified the milestones: v0.48.0, v0.50.0, v0.49.0 Oct 12, 2023
@codebien codebien marked this pull request as ready for review January 18, 2024 12:04
@codebien codebien requested a review from a team as a code owner January 18, 2024 12:04
@codebien
Copy link
Contributor Author

Please run cloud integration tests first

Done, they passed 🎉

@codebien codebien requested review from olegbespalov and removed request for a team January 18, 2024 12:06
olegbespalov
olegbespalov previously approved these changes Jan 18, 2024
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great stuff!

@mstoykov mstoykov mentioned this pull request Jan 18, 2024
@codebien
Copy link
Contributor Author

codebien commented Feb 2, 2024

Rebased and resolved the conflicts

@codebien codebien merged commit 42035d3 into master Feb 12, 2024
24 checks passed
@codebien codebien deleted the attempt-drop-cloudv1 branch February 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants