-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudv2: s/ReferenceID/TestRunID/ #3137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3137 +/- ##
==========================================
- Coverage 72.78% 72.77% -0.02%
==========================================
Files 255 255
Lines 19585 19585
==========================================
- Hits 14255 14253 -2
- Misses 4433 4435 +2
Partials 897 897
Flags with carried forward coverage won't be shown. Click here to find out more.
|
👋 Just in case it's useful: recently it was noticed that the endpoints used by cloudapi v1 are actually an exception in the API and not the norm. Issue on topic: https://github.com/grafana/k6-cloud/issues/1469 Note: the term "reference ID" is also mentioned there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "reference ID" is a remnant of how this was referred to by the backend, as @yorugac mentions, and not something that we came up with in k6.
I'm fine with this change, though we should add a comment somewhere that this field is known as "reference ID" in the backend, or if that's now being phased out, that it was the legacy name for v1.
It represents a testRunID so why not directly call it in that way?!
5192fad
to
a6f5a77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I've renamed most of the
referenceID
occurrences totestRunID
. It should now be more consistent with the business domain.I wonder why we had it before so if someone can recall, it would be great. I avoid renaming the
v1
internal occurrences as we plan to drop the entirev1
soon.