Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudv2: s/ReferenceID/TestRunID/ #3137

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Conversation

codebien
Copy link
Contributor

I've renamed most of the referenceID occurrences to testRunID. It should now be more consistent with the business domain.

I wonder why we had it before so if someone can recall, it would be great. I avoid renaming the v1 internal occurrences as we plan to drop the entire v1 soon.

@codebien codebien added this to the v0.46.0 milestone Jun 26, 2023
@codebien codebien self-assigned this Jun 26, 2023
@github-actions github-actions bot requested review from imiric and mstoykov June 26, 2023 10:39
@codebien codebien changed the title Cloudv2 rename referenceid cloudv2: s/ReferenceID/TestRunID/ Jun 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #3137 (9d7218b) into master (aa79387) will decrease coverage by 0.02%.
The diff coverage is 85.00%.

❗ Current head 9d7218b differs from pull request most recent head a6f5a77. Consider uploading reports for the commit a6f5a77 to get more accurate results

@@            Coverage Diff             @@
##           master    #3137      +/-   ##
==========================================
- Coverage   72.78%   72.77%   -0.02%     
==========================================
  Files         255      255              
  Lines       19585    19585              
==========================================
- Hits        14255    14253       -2     
- Misses       4433     4435       +2     
  Partials      897      897              
Flag Coverage Δ
ubuntu 72.70% <85.00%> (-0.03%) ⬇️
windows 72.63% <85.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloudapi/config.go 90.65% <ø> (ø)
output/cloud/v1/output.go 67.81% <ø> (ø)
output/cloud/expv2/output.go 66.01% <75.00%> (ø)
output/cloud/output.go 75.33% <85.71%> (ø)
output/cloud/expv2/flush.go 86.95% <100.00%> (ø)

... and 1 file with indirect coverage changes

@codebien codebien mentioned this pull request Jun 26, 2023
@yorugac
Copy link
Contributor

yorugac commented Jun 26, 2023

👋 Just in case it's useful: recently it was noticed that the endpoints used by cloudapi v1 are actually an exception in the API and not the norm. Issue on topic: https://github.com/grafana/k6-cloud/issues/1469 Note: the term "reference ID" is also mentioned there.

imiric
imiric previously approved these changes Jun 26, 2023
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "reference ID" is a remnant of how this was referred to by the backend, as @yorugac mentions, and not something that we came up with in k6.

I'm fine with this change, though we should add a comment somewhere that this field is known as "reference ID" in the backend, or if that's now being phased out, that it was the legacy name for v1.

output/cloud/v1/output.go Show resolved Hide resolved
imiric
imiric previously approved these changes Jun 26, 2023
olegbespalov
olegbespalov previously approved these changes Jun 27, 2023
output/cloud/output.go Outdated Show resolved Hide resolved
@codebien codebien dismissed stale reviews from olegbespalov and imiric via a6f5a77 July 5, 2023 12:33
@codebien codebien force-pushed the cloudv2-rename-referenceid branch from 5192fad to a6f5a77 Compare July 5, 2023 12:33
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codebien codebien merged commit e1e22ba into master Jul 5, 2023
20 checks passed
@codebien codebien deleted the cloudv2-rename-referenceid branch July 5, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants