Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudv2: Not replicate common fields #3144

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Jun 27, 2023

What?

It moves the repeated fields in a shared place and then the backend will denormalize them.

Why?

It reduces memory allocation on k6 open source.

Related PR(s)/Issue(s)

Updates #3117

@codebien codebien added this to the v0.46.0 milestone Jun 27, 2023
@codebien codebien self-assigned this Jun 27, 2023
@codebien codebien mentioned this pull request Jun 28, 2023
@codebien codebien force-pushed the cloudv2-proto-common-fields branch from 1521185 to c38bcd7 Compare June 29, 2023 07:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #3144 (c3749c7) into master (1df72a0) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

❗ Current head c3749c7 differs from pull request most recent head c38bcd7. Consider uploading reports for the commit c38bcd7 to get more accurate results

@@            Coverage Diff             @@
##           master    #3144      +/-   ##
==========================================
- Coverage   71.98%   71.98%   -0.01%     
==========================================
  Files         252      252              
  Lines       19405    19403       -2     
==========================================
- Hits        13969    13967       -2     
- Misses       4542     4543       +1     
+ Partials      894      893       -1     
Flag Coverage Δ
ubuntu 71.91% <40.00%> (+<0.01%) ⬆️
windows 71.83% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/expv2/hdr.go 95.71% <ø> (-0.12%) ⬇️
output/cloud/expv2/pbcloud/metric.pb.go 8.42% <0.00%> (-0.06%) ⬇️
output/cloud/expv2/flush.go 86.95% <100.00%> (ø)
output/cloud/expv2/mapping.go 42.64% <100.00%> (-2.43%) ⬇️

... and 2 files with indirect coverage changes

@codebien codebien marked this pull request as ready for review June 29, 2023 14:21
@github-actions github-actions bot requested review from imiric and mstoykov June 29, 2023 14:21
@codebien
Copy link
Contributor Author

codebien commented Jun 29, 2023

I still need to iterate on #3144 (comment) but we can do reviews in async considering how small the impact should be.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have a naming suggestion.

Also, isn't this technically a breaking change for the backend, since they will now read the test run ID and aggregation period from the top MetricSet object? Have you coordinated this with them?

output/cloud/expv2/pbcloud/metric.proto Show resolved Hide resolved
@codebien codebien merged commit aa79387 into master Jul 5, 2023
@codebien codebien deleted the cloudv2-proto-common-fields branch July 5, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants