-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudv2: Not replicate common fields #3144
Conversation
1521185
to
c38bcd7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3144 +/- ##
==========================================
- Coverage 71.98% 71.98% -0.01%
==========================================
Files 252 252
Lines 19405 19403 -2
==========================================
- Hits 13969 13967 -2
- Misses 4542 4543 +1
+ Partials 894 893 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I still need to iterate on #3144 (comment) but we can do reviews in async considering how small the impact should be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just have a naming suggestion.
Also, isn't this technically a breaking change for the backend, since they will now read the test run ID and aggregation period from the top MetricSet
object? Have you coordinated this with them?
What?
It moves the repeated fields in a shared place and then the backend will denormalize them.
Why?
It reduces memory allocation on k6 open source.
Related PR(s)/Issue(s)
Updates #3117