-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing the MaxTimeSeriesInBatch config option #3157
Conversation
a381a43
to
b554eba
Compare
b554eba
to
ecbe215
Compare
Codecov Report
@@ Coverage Diff @@
## master #3157 +/- ##
==========================================
- Coverage 72.80% 72.75% -0.06%
==========================================
Files 255 253 -2
Lines 19581 19582 +1
==========================================
- Hits 14256 14246 -10
- Misses 4429 4434 +5
- Partials 896 902 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments. Thanks for taking care.
Can you please add a validation rule like we have for the old option?
Lines 116 to 119 in 3291b98
if conf.MaxMetricSamplesPerPackage.Int64 < 1 { | |
return nil, fmt.Errorf("metric samples per package must be a positive number but is %d", | |
conf.MaxMetricSamplesPerPackage.Int64) | |
} |
Moving cloud output v2 from MaxMetricSamplesPerPackage to MaxTimeSeriesInBatch, to have a flexibility and better reflect the actual usage of the option.
ecbe215
to
c37e284
Compare
What?
Moving cloud output v2 from MaxMetricSamplesPerPackage to MaxTimeSeriesInBatch.
Why?
The new option reflects the actual purpose and usage of the config option.
Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3156