-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental/fs read all #3229
Closed
Closed
Experimental/fs read all #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
experimental/fs-readAll
branch
from
August 24, 2023 12:53
0ad3f52
to
fa90552
Compare
oleiade
force-pushed
the
experimental/fs-readAll
branch
from
August 24, 2023 12:57
fa90552
to
b09639b
Compare
oleiade
force-pushed
the
experimental/fs-readAll
branch
from
August 29, 2023 14:19
b09639b
to
1361e0a
Compare
oleiade
changed the base branch from
experimental/fs-read
to
experimental/fs-readseek
August 29, 2023 14:19
oleiade
force-pushed
the
experimental/fs-readAll
branch
from
August 29, 2023 14:21
1361e0a
to
c6975ea
Compare
Codecov Report
@@ Coverage Diff @@
## experimental/fs-readseek #3229 +/- ##
===========================================================
Coverage ? 73.14%
===========================================================
Files ? 261
Lines ? 20072
Branches ? 0
===========================================================
Hits ? 14681
Misses ? 4451
Partials ? 940
Flags with carried forward coverage won't be shown. Click here to find out more. |
oleiade
force-pushed
the
experimental/fs-readAll
branch
from
August 29, 2023 14:58
c6975ea
to
beeb096
Compare
oleiade
force-pushed
the
experimental/fs-readseek
branch
4 times, most recently
from
September 27, 2023 09:06
6d8dbb3
to
28ee0ef
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This Pull Request adds a
readAll
method to thek6/experimental/fs
module'sFile
object, as per #3147.experimental/fs-read
branch.It enables users to read the whole content of a file in one go, in an asynchronous manner. The method returns a promise which resolves to an
ArrayBuffer
holding the file data.Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
ref #3219
closes #3147