-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracing module sampling option should default to 1.0 when not set #3231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This commit ensures that if the `sampling` option of the tracing module's client is not provided by user, the Client defaults to sample 100% of the request.
bb608a2
to
9ea8a8f
Compare
It turns out this was caused by a difference in how options are handled between the client and the options. I addressed the issue differently and ensured all the tests passed now. |
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
==========================================
- Coverage 73.24% 73.24% -0.01%
==========================================
Files 259 259
Lines 19892 19899 +7
==========================================
+ Hits 14570 14575 +5
- Misses 4400 4401 +1
- Partials 922 923 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What?
This Pull Request ensures that if the
sampling
option of the tracing module's client is not provided by the user, the Client defaults to sample 100% of the request.Why?
As noted by @Blinkuu, the current behavior of the tracing module client is to use a 0% sampling when the option is not set. It leads to effectively no HTTP request being sampled. Whereas the desired behavior would be to have all requests sampled unless instructed otherwise.
Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.