Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-json parser for http responses #3248

Closed
wants to merge 6 commits into from
Closed

Use go-json parser for http responses #3248

wants to merge 6 commits into from

Conversation

davidpst
Copy link
Contributor

@davidpst davidpst commented Aug 3, 2023

Implements JSON decoder using go-json for http response (#3247)

I have added a test comparing the two versions:

encoding/json
BenchmarkUnmarshalJson-10 415700 2792 ns/op 1176 B/op 7 allocs/op

goccy/go-json
BenchmarkUnmarshalJson-10 7477863 139.9 ns/op 912 B/op 2 allocs/op

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #3248 (3791e95) into master (9598ef5) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 3791e95 differs from pull request most recent head 0cb02b1. Consider uploading reports for the commit 0cb02b1 to get more accurate results

@@            Coverage Diff             @@
##           master    #3248      +/-   ##
==========================================
- Coverage   73.21%   73.17%   -0.05%     
==========================================
  Files         258      256       -2     
  Lines       19884    19880       -4     
==========================================
- Hits        14559    14547      -12     
- Misses       4402     4405       +3     
- Partials      923      928       +5     
Flag Coverage Δ
ubuntu 73.17% <100.00%> (+0.02%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
js/modules/k6/http/response.go 80.00% <100.00%> (+0.14%) ⬆️

... and 8 files with indirect coverage changes

@oleiade
Copy link
Member

oleiade commented Aug 9, 2023

Hey @davidpst, as mentioned in the linked issue, we would rather not merge this at the moment, for the reasons mentioned there. If that's okay with you, I would close this PR 👍🏻

@oleiade oleiade closed this Aug 16, 2023
@davidpst davidpst deleted the feature/fasthttp-client branch August 17, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants