Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote image tag when tagging :latest-with-browser images #3256

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

andrewslotin
Copy link
Contributor

What?

Fixes a syntax error in the build pipeline that publishes built Docker images to Docker Hub.

Why?

Current build pipeline is broken due to a syntax error. This prevents CI from pushing the grafana/k6:latest-with-browser images to Docker hub as well as legacy loadimpact/k6

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.

@codecov-commenter
Copy link

Codecov Report

Merging #3256 (e7f7492) into master (b7f040b) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head e7f7492 differs from pull request most recent head 546c391. Consider uploading reports for the commit 546c391 to get more accurate results

@@            Coverage Diff             @@
##           master    #3256      +/-   ##
==========================================
- Coverage   73.22%   73.08%   -0.15%     
==========================================
  Files         259      257       -2     
  Lines       19899    19897       -2     
==========================================
- Hits        14571    14541      -30     
- Misses       4404     4424      +20     
- Partials      924      932       +8     
Flag Coverage Δ
ubuntu ?
windows 73.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

@andrewslotin andrewslotin merged commit 5b5c5cc into master Aug 4, 2023
21 checks passed
@andrewslotin andrewslotin deleted the fix_docker_build_pipeline branch August 4, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants