Add additional usages #3951
Merged
Add additional usages #3951
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This both allows us to figure out if users are using k6 with a lot of files and if ts support is actually used.
It will be nice to know how many people use require and potentially commonJS. Note: this reports each invocation of `require` but adding sync.Once to this seems overkill and it is probably okay to have the statistics either way.
As part of #3864 it will be nice to know how much this is used if at all.
mstoykov
added
the
documentation-needed
mstoykov
requested review from
olegbespalov and
joanlopez
and removed request for
a team
joanlopez
approved these changes
Sep 13, 2024
olegbespalov
approved these changes
Sep 13, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add reporting some additional usages to better figure how k6 is used.
Why?
We do need to make decisions on what to work on or break or keep working if it is problematic.
We usually make a lot of those based on anecdotal data or only on data we have access through direct communication with customers. This is not terrible but definitely leaves us with blind spots.
The newly added usage counters have descriptions in each of the commits and are used for different areas where we might decide to cleanup k6 or work more on a give feature.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)