Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest browser v1.8.2 #3963

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Update to latest browser v1.8.2 #3963

merged 2 commits into from
Sep 20, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Sep 20, 2024 •
edited
Loading

What?

Update to latest browser v1.8.2

Why?

  • Includes the memory leak fix that was a regression.
  • Includes the NPD fix.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

grafana/xk6-browser#1429
grafana/xk6-browser#1432

@ankur22
Update to latest browser v1.8.1
1ab4594 
Includes the memory leak fix that was a regression.
@ankur22 ankur22 requested a review from a team as a code owner September 20, 2024 08:47
@ankur22 ankur22 requested review from joanlopez and removed request for a team September 20, 2024 08:47
ankur22
ankur22 commented Sep 20, 2024
View reviewed changes
go.mod Outdated
@@ -15,7 +15,7 @@ require (
github.com/go-sourcemap/sourcemap v2.1.4+incompatible
github.com/golang/protobuf v1.5.4
github.com/gorilla/websocket v1.5.1
github.com/grafana/xk6-browser v1.8.0
github.com/grafana/xk6-browser v1.8.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPD fix inbound.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fe5c747

@ankur22
Update to v1.8.2 of browser
fe5c747 
This has the NPD fix when the browser module aborts very early on.
@ankur22 ankur22 changed the title Update to latest browser v1.8.1 Update to latest browser v1.8.2 Sep 20, 2024
@ankur22 ankur22 merged commit 556751c into master Sep 20, 2024
22 checks passed
@ankur22 ankur22 deleted the update/browser-1.8.1 branch September 20, 2024 10:53
@olegbespalov olegbespalov added this to the v0.54.0 milestone Sep 23, 2024
@olegbespalov olegbespalov added the dependencies Pull requests that update a dependency file label Sep 23, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiade oleiade oleiade approved these changes

@andrewslotin andrewslotin andrewslotin approved these changes

@joanlopez joanlopez Awaiting requested review from joanlopez joanlopez is a code owner automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ankur22 @andrewslotin @oleiade @olegbespalov