Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fatih/color and set the logo color to be the correct RGB one #4029

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Update fatih/color and use the RGB functionality to match the banner logo to the official k6 color.

Why?

RGB ✨

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.55.0 milestone Oct 30, 2024
@mstoykov mstoykov requested a review from a team as a code owner October 30, 2024 09:01
@mstoykov mstoykov requested review from oleiade and olegbespalov and removed request for a team October 30, 2024 09:01
olegbespalov
olegbespalov previously approved these changes Oct 30, 2024
@joanlopez
Copy link
Contributor

joanlopez commented Oct 30, 2024

Previously

image

Now

image

Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PS: I left a couple of screenshots with the comparison

@oleiade
Copy link
Member

oleiade commented Oct 30, 2024

Here's what it looks like on Windows (powershell)
Screenshot 2024-10-30 122212

@mstoykov mstoykov merged commit c408b44 into master Oct 30, 2024
22 checks passed
@mstoykov mstoykov deleted the rgb branch October 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants