Do not send interrupted iteartions' duration to the cloud ingest API #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in #710 I fixed a bug in k6 so that some metrics aren't emitted when an iteration is canceled, a bug that was introduced by the real-time metrics refactoring (which was itself needed for the in-k6 data aggregation). In the case of the metrics emitted at the end of an iteration, I made it so that the
data_sentanddata_receivedmetrics are always emitted, but theiteration_durationmetric would only be emitted for complete iterations.The trouble comes from the fact that I forgot that we bundle iteration metrics in a
iter_li_allmetric for the cloud collector. So theiteration_durationwas sent there even if the iteration was incomplete, so this PR makes the cloud collector behave like the rest.