Skip to content

Commit

Permalink
Remove Frontend Observability feature (#818)
Browse files Browse the repository at this point in the history
Signed-off-by: Pete Wall <pete.wall@grafana.com>
  • Loading branch information
petewall authored Oct 25, 2024
1 parent d38255c commit b7f5f71
Show file tree
Hide file tree
Showing 31 changed files with 9 additions and 334 deletions.
6 changes: 0 additions & 6 deletions charts/feature-frontend-observability/.helmignore

This file was deleted.

3 changes: 0 additions & 3 deletions charts/feature-frontend-observability/Chart.lock

This file was deleted.

13 changes: 0 additions & 13 deletions charts/feature-frontend-observability/Chart.yaml

This file was deleted.

38 changes: 0 additions & 38 deletions charts/feature-frontend-observability/Makefile

This file was deleted.

46 changes: 0 additions & 46 deletions charts/feature-frontend-observability/README.md

This file was deleted.

33 changes: 0 additions & 33 deletions charts/feature-frontend-observability/README.md.gotmpl

This file was deleted.

17 changes: 0 additions & 17 deletions charts/feature-frontend-observability/templates/_helpers.tpl

This file was deleted.

22 changes: 0 additions & 22 deletions charts/feature-frontend-observability/templates/_module.alloy.tpl

This file was deleted.

11 changes: 0 additions & 11 deletions charts/feature-frontend-observability/templates/_notes.tpl

This file was deleted.

15 changes: 0 additions & 15 deletions charts/feature-frontend-observability/values.schema.json

This file was deleted.

12 changes: 0 additions & 12 deletions charts/feature-frontend-observability/values.yaml

This file was deleted.

12 changes: 6 additions & 6 deletions charts/k8s-monitoring/.updatecli-alloy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ conditions:
kind: yaml
spec:
file: charts/k8s-monitoring/Chart.yaml
key: $.dependencies[9].name
key: $.dependencies[8].name
value: alloy
disablesourceinput: true
targets:
Expand All @@ -25,7 +25,7 @@ targets:
kind: helmchart
spec:
file: Chart.yaml
key: $.dependencies[9].version
key: $.dependencies[8].version
name: charts/k8s-monitoring
versionincrement: none
sourceid: alloy
Expand All @@ -34,7 +34,7 @@ targets:
kind: helmchart
spec:
file: Chart.yaml
key: $.dependencies[10].version
key: $.dependencies[9].version
name: charts/k8s-monitoring
versionincrement: none
sourceid: alloy
Expand All @@ -43,7 +43,7 @@ targets:
kind: helmchart
spec:
file: Chart.yaml
key: $.dependencies[11].version
key: $.dependencies[10].version
name: charts/k8s-monitoring
versionincrement: none
sourceid: alloy
Expand All @@ -52,7 +52,7 @@ targets:
kind: helmchart
spec:
file: Chart.yaml
key: $.dependencies[12].version
key: $.dependencies[11].version
name: charts/k8s-monitoring
versionincrement: none
sourceid: alloy
Expand All @@ -61,7 +61,7 @@ targets:
kind: helmchart
spec:
file: Chart.yaml
key: $.dependencies[13].version
key: $.dependencies[12].version
name: charts/k8s-monitoring
versionincrement: none
sourceid: alloy
7 changes: 2 additions & 5 deletions charts/k8s-monitoring/Chart.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ dependencies:
- name: k8s-monitoring-feature-cluster-metrics
repository: file://../feature-cluster-metrics
version: 1.0.0
- name: k8s-monitoring-feature-frontend-observability
repository: file://../feature-frontend-observability
version: 1.0.0
- name: k8s-monitoring-feature-integrations
repository: file://../feature-integrations
version: 1.0.0
Expand Down Expand Up @@ -41,5 +38,5 @@ dependencies:
- name: alloy
repository: https://grafana.github.io/helm-charts
version: 0.9.1
digest: sha256:734d4c8f6076481eb580378daa65fe163c78e9e07a1a214cb4b2fed16441b4c9
generated: "2024-10-22T11:10:21.255416+02:00"
digest: sha256:4cac24fb5b4c8dba5508a79980ae781c65da75bcf2a279967bc8c5d7f9e4fad4
generated: "2024-10-25T15:57:55.519739+02:00"
5 changes: 0 additions & 5 deletions charts/k8s-monitoring/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ dependencies:
repository: file://../feature-cluster-metrics
version: 1.0.0
condition: clusterMetrics.enabled
- alias: frontendObservability
name: k8s-monitoring-feature-frontend-observability
repository: file://../feature-frontend-observability
version: 1.0.0
condition: frontendObservability.enabled
- alias: integrations
name: k8s-monitoring-feature-integrations
repository: file://../feature-integrations
Expand Down
9 changes: 0 additions & 9 deletions charts/k8s-monitoring/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ podLogs:
| file://../feature-application-observability | applicationObservability(k8s-monitoring-feature-application-observability) | 1.0.0 |
| file://../feature-cluster-events | clusterEvents(k8s-monitoring-feature-cluster-events) | 1.0.0 |
| file://../feature-cluster-metrics | clusterMetrics(k8s-monitoring-feature-cluster-metrics) | 1.0.0 |
| file://../feature-frontend-observability | frontendObservability(k8s-monitoring-feature-frontend-observability) | 1.0.0 |
| file://../feature-integrations | integrations(k8s-monitoring-feature-integrations) | 1.0.0 |
| file://../feature-pod-logs | podLogs(k8s-monitoring-feature-pod-logs) | 1.0.0 |
| file://../feature-profiling | profiling(k8s-monitoring-feature-profiling) | 1.0.0 |
Expand Down Expand Up @@ -243,14 +242,6 @@ podLogs:
|-----|------|---------|-------------|
| destinations | list | `[]` | The list of destinations where telemetry data will be sent. See the [destinations documentation](https://github.com/grafana/k8s-monitoring-helm/blob/main/charts/k8s-monitoring/docs/destinations/README.md) for more information. |

### Features - Frontend Observability

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| frontendObservability | object | Disabled | Front-end Observability enables the Faro receiver for accepting traces and logs from front-end applications. Requires a destination that supports metrics, logs, and traces. To see the valid options, please see the [Front-end Observability feature documentation](https://github.com/grafana/k8s-monitoring-helm/tree/main/charts/feature-frontend-observability). |
| frontendObservability.destinations | list | `[]` | The destinations where cluster events will be sent. If empty, all traces and logs-capable destinations will be used. |
| frontendObservability.enabled | bool | `false` | Enable gathering front-end observability data. |

### Global Settings

| Key | Type | Default | Description |
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
6 changes: 0 additions & 6 deletions charts/k8s-monitoring/docs/Features.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ Collects metrics and logs from a variety of popular services and integrations.

Collect profiles using Pyroscope.

## Frontend Observability

[Documentation](https://github.com/grafana/k8s-monitoring-helm/tree/main/charts/feature-frontend-observability)

Open a Faro receiver to collect telemetry data from instrumented frontend applications.

## Contributing

Features are stored in their own Helm chart. That chart is not a standalone chart, but is included in the main
Expand Down
1 change: 0 additions & 1 deletion charts/k8s-monitoring/schema-mods/types-and-enums.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"clusterEvents": {"properties": {"destinations": { "uniqueItems": true, "items": { "type": "string" }}}},
"clusterMetrics": {"properties": {"destinations": { "uniqueItems": true, "items": { "type": "string" }}}},
"podLogs": {"properties": {"destinations": { "uniqueItems": true, "items": { "type": "string" }}}},
"frontendObservability": {"properties": {"destinations": { "uniqueItems": true, "items": { "type": "string" }}}},

"destinations": {"$ref": "#/definitions/destination-list"}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

{{- $collectorName = "alloy-receiver" }}
{{- if (index .Values $collectorName).enabled }}
{{- $atLeastOneFeatureEnabled := or .Values.applicationObservability.enabled .Values.frontendObservability.enabled }}
{{- $atLeastOneFeatureEnabled := or .Values.applicationObservability.enabled }}
{{- if not $atLeastOneFeatureEnabled }}
{{- fail (printf $errorMessage $collectorName $collectorName) }}
{{- end }}
Expand Down
Loading

0 comments on commit b7f5f71

Please sign in to comment.