Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the option for loading alloy modules embedded in the chart, rather than from git #843

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

petewall
Copy link
Collaborator

@petewall petewall commented Nov 6, 2024

Signed-off-by: Pete Wall pete.wall@grafana.com

Signed-off-by: Pete Wall <pete.wall@grafana.com>
…ther than from git.

Signed-off-by: Pete Wall <pete.wall@grafana.com>
@petewall petewall self-assigned this Nov 6, 2024
@petewall petewall requested review from a team, simonswine and rlankfo as code owners November 6, 2024 02:03
@petewall petewall linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Member

@skl skl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

The modules you've chosen to vendor - is that based on the modules which are used/available by default in the chart? Presumably this works toward having an "air-gapped"/self-contained build of the chart.

Is it "all or nothing" for the git/configmap choice? i.e. if I choose configMap then I need to ensure that all of the chart's modules are defined in configmaps and all of their files are available on disk, before I start to add more modules? Does the vendoring help with that?

Thinking aloud a bit here but love the direction this is going 😄

This will improve when carvel-dev/docker-image#16 is merged.

Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
@petewall
Copy link
Collaborator Author

petewall commented Nov 6, 2024

is that based on the modules which are used/available by default in the chart?

It is, but not via automation. It's picked by the vendir.yml file. It's manual for now, but it could be extracted from the code at some point.

Is it "all or nothing" for the git/configmap choice? i.e. if I choose configMap then I need to ensure that all of the chart's modules are defined in configmaps and all of their files are available on disk, before I start to add more modules? Does the vendoring help with that?

Currently, yes, it is all or nothing. It's a first drop. At some point, making the module location configurable for each would be nice, especially if we need to override for whatever reason. But this satisfies one community tester's problem of "my cluster can't access git".

…dule

Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
@petewall petewall merged commit aa2ae9d into main Nov 6, 2024
36 checks passed
@petewall petewall deleted the feat/alloy-modules-without-git branch November 6, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0 customize import.git location in alloy configuration
2 participants