Skip to content

Conversation

@LukoJy3D
Copy link
Contributor

@LukoJy3D LukoJy3D commented Nov 6, 2025

What this PR does / why we need it:

In 91e11fc, image registry standardization was introduced, yet it only overrides components using baseImage.

If all good with such approach will update docs to note this change and problems noted in the referenced issue

Which issue(s) this PR fixes:
#19662

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@LukoJy3D LukoJy3D requested a review from a team as a code owner November 6, 2025 12:16
@LukoJy3D LukoJy3D changed the title fix(helm): pass full global values to image helper to respect new standartization fix(helm): pass full global values to image helper to respect new image standardization Nov 6, 2025
@LukoJy3D LukoJy3D force-pushed the fix/helm/pass_full_global_values_to_image_to_respect_standartized_registry branch from 2c2c4e6 to ec31b6f Compare November 6, 2025 12:43
@jkroepke
Copy link
Contributor

jkroepke commented Nov 8, 2025

Hi @LukoJy3D

I favorite #19347 - or I do not get the root cause of #19662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants