Skip to content

Conversation

@slim-bean
Copy link
Collaborator

@slim-bean slim-bean commented Dec 3, 2025

What this PR does / why we need it:

Adding stats for how long we spend on blooms filtering also fixing frontend logging of the stats i added last week on result size, we never set the result object to be passed into the functions that pring our metrics.go line from the frontend middleware. this meant the change I did last week to include result size wasn't working in the frontend.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean slim-bean requested a review from a team as a code owner December 3, 2025 02:46
@slim-bean slim-bean changed the title chore: make sure we populate the result object when calculating stats/metrics.go in the frontend middleware chore: improve metrics.go stats logging to include bloom filter time as well as fix missing size info in query-frontend Dec 4, 2025
@slim-bean slim-bean merged commit 0ecb4fb into main Dec 4, 2025
70 checks passed
@slim-bean slim-bean deleted the better-metrics-go-2 branch December 4, 2025 19:27
loki-gh-app bot pushed a commit that referenced this pull request Dec 4, 2025
…as well as fix missing size info in query-frontend (#20093)

(cherry picked from commit 0ecb4fb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants