Skip to content

Commit

Permalink
Temporarily fix weird test flake.
Browse files Browse the repository at this point in the history
  • Loading branch information
seizethedave committed Jan 2, 2025
1 parent a1e2945 commit 6206183
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions pkg/blockbuilder/blockbuilder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func TestBlockBuilder_StartWithExistingCommit_PullMode(t *testing.T) {
scheduler.addJob(
schedulerpb.JobKey{
Id: "test-job-4898",
Epoch: 84823,
Epoch: 90000,
},
schedulerpb.JobSpec{
Topic: testTopic,
Expand Down Expand Up @@ -360,7 +360,7 @@ func TestBlockBuilder_StartWithLookbackOnNoCommit_PullMode(t *testing.T) {
scheduler.addJob(
schedulerpb.JobKey{
Id: "test-job-4898",
Epoch: 84823,
Epoch: 90001,
},
schedulerpb.JobSpec{
Topic: testTopic,
Expand Down Expand Up @@ -408,7 +408,6 @@ func TestBlockBuilder_ReachHighWatermarkBeforeLastCycleSection(t *testing.T) {
t.Cleanup(func() { cancel(errors.New("test done")) })

kafkaCluster, kafkaAddr := testkafka.CreateClusterWithoutCustomConsumerGroupsSupport(t, numPartitions, testTopic)

kafkaClient := mustKafkaClient(t, kafkaAddr)

cfg, overrides := blockBuilderConfig(t, kafkaAddr)
Expand Down Expand Up @@ -479,7 +478,8 @@ func TestBlockBuilder_ReachHighWatermarkBeforeLastCycleSection(t *testing.T) {

// When there are no records to consume before the last cycle section, the whole cycle should bail.
func TestBlockBuilder_ReachHighWatermarkBeforeLastCycleSection_PullMode(t *testing.T) {
t.Parallel()
// FIXME: I'm currently trying to understand why uncommenting this line causes tests to fail when all run together:
// t.Parallel()

ctx, cancel := context.WithCancelCause(context.Background())
t.Cleanup(func() { cancel(errors.New("test done")) })
Expand Down Expand Up @@ -522,7 +522,7 @@ func TestBlockBuilder_ReachHighWatermarkBeforeLastCycleSection_PullMode(t *testi
scheduler.addJob(
schedulerpb.JobKey{
Id: "test-job-p0-4898",
Epoch: 84823,
Epoch: 90002,
},
schedulerpb.JobSpec{
Topic: testTopic,
Expand All @@ -540,7 +540,7 @@ func TestBlockBuilder_ReachHighWatermarkBeforeLastCycleSection_PullMode(t *testi
scheduler.addJob(
schedulerpb.JobKey{
Id: "test-job-p1-4899",
Epoch: 84824,
Epoch: 90070,
},
schedulerpb.JobSpec{
Topic: testTopic,
Expand Down Expand Up @@ -662,7 +662,7 @@ func TestBlockBuilder_WithMultipleTenants_PullMode(t *testing.T) {
scheduler.addJob(
schedulerpb.JobKey{
Id: "test-job-4898",
Epoch: 84823,
Epoch: 90003,
},
schedulerpb.JobSpec{
Topic: testTopic,
Expand Down

0 comments on commit 6206183

Please sign in to comment.