-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: add commonLabels (#9067) #10385
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NickAnge, |
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
Signed-off-by: fabio trigari <trigarifabio@gmail.com>
Could you add a unit-test for this change? I don't think it's worth having a separate test, so maybe only add a simple case to the existing After that, you'll need to run |
# -- Common labels for all object directly managed this chart. | ||
# scope: * | ||
commonLabels: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is the use-case for the feature, but I should point out that — in the current implementation — the global.commonLabels
seem to only add labels to the top-level resources (e.g. deployments, statefulsets, configmaps, etc). It doesn't add labels to the resources, controlled by those top-levels, e.g. pods, that a deployment creates. This may be fine.
What this PR does
Every object created by the chart could have custom labels.
Which issue(s) this PR fixes or relates to
Fixes #9067
--- EDIT ---
I made a mess with my branch. I erased all and created a new commit.
This is the old PR #9742
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.