-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates doc on otel resource attributes promoted to labels #10685
base: main
Are you sure you want to change the base?
Conversation
💻 Deploy preview available: https://deploy-preview-mimir-10685-zb444pucvq-vp.a.run.app/docs/mimir/latest/ |
Here's a draft of the docs for OTel resource attribute promotion. @zhehao-grafana could you please review and determine what additional information users need to know? @aknuds1 and @jesusvazquez could you please review for technical accuracy and provide missing information on how users can update the list of attributes automatically assigned as labels? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
If you are using Grafana Cloud, contact support to disable this setting or to update this list. | ||
|
||
{{< admonition type="note" >}} | ||
Some of these labels are mutually exclusive. If you don't need a particular label, you can aggregate it using Adaptive Metrics. For more information about Adaptive Metrics, refer to [Reduce metrics costs via Adaptive Metrics](https://grafana.com/docs/grafana-cloud/cost-management-and-billing/adaptive-telemetry/adaptive-metrics/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the note refer to the list of resource attributes above (as opposed to labels)? Do you have examples of mutually exclusive ones? Not sure how to interpret the note.
If you are referring to resource attributes, why not avoid promoting them instead of aggregating the resulting labels away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, they are resource attributes. I actually think this note might add more confusion than clarity, and I'm going to remove it.
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does
This PR adds documentation for OTel resource attributes being automatically promoted to labels in Mimir.
Which issue(s) this PR fixes or relates to
Fixes https://github.com/grafana/mimir-squad/issues/2727
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.