Increase block-ranges-period for OOO native histogram integration test #9592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
approved these changes
Oct 14, 2024
| @@ -168,6 +168,12 @@ func TestOOOHistogramIngestionDisabled(t *testing.T) { | |||
| map[string]string{ | |||
| "-ingester.out-of-order-time-window": "10m", | |||
| "-ingester.native-histograms-ingestion-enabled": "true", | |||
| // Default block-ranges-period for integration tests is 1m | |||
There was a problem hiding this comment.
nit: let's add "-ingester.ooo-native-histograms-ingestion-enabled": "false" while we're at it. Just in case we change the default/remove the flag, make the test fail more explicitly.
There was a problem hiding this comment.
Updated in aeb921c
krajorama
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is a follow up to #9567 - that PR spotted an issue where the OOO native histograms disabled error was not being mapped to a client error.
Prior to that PR, we already had an integration test that checked that trying to ingest OOO NH samples when the OOO NH flag was disabled returned a 400 and that test actually passed. The reason why it passed was that another 400 error being returned (out of bounds) - this is as
-blocks-storage.tsdb.block-ranges-period, which is used to determine if a sample is out of bounds, is set to a very low value in tests. I've increased this value the out of bounds check passes and the OOO NH disabled error is hit instead.Note that the test expectations haven't changed - we check OOO NH samples error with a 400, but the underlying error is now the OOO NH disabled error (I checked by running the test and looking at logs). The current integration test Mimir client doesn't return the response body so we can only access the status code. The bugfix PR (#9567) has a unit test that checks the specific error is returned. It's still useful to modify
-blocks-storage.tsdb.block-ranges-periodjust in case in the future we accidentally start mapping the OOO NH error incorrectly again.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.