Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add GEM federation-frontend resources #9673

Merged
merged 9 commits into from
Nov 11, 2024

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Oct 18, 2024

What this PR does

This PR adds the federation-frontend resources to the Helm chart. The goal is to have the federation-frontend deployed on its own.

  • Adds resources for the federation-frontend
    • Service
    • Deployment
    • PodDisruptionBudget
    • ServiceMonitor (if meta-monitoring is enabled)
  • Adds an offline test with the current way of deploying a stand-alone federation-frontend:
    • GEM gateway (to allow deploying the federation-frontend in an existing cluster)
    • admin-api, so that the GEM license is set up in case this is a standalone GEM cluster too (albeit with a single query component)
    • minio to allow local testing for the admin-api
    • most other components are scaled to 0 replicas or disabled. My plan is to later add enabled toggles for all components so there are no unrelated components deployed

I've tested this locally with the test-enterprise-federation-frontend-values.yaml (+ license) by deploying a Mimir cluster and pointing the federation-frontend to it

Screenshot 2024-10-18 at 15 32 17

Which issue(s) this PR fixes or relates to

related to #9672

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/helm/federation-frontend branch from bc2b7ea to 6278ee6 Compare October 18, 2024 14:13
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Looks good to me.

(Thinking out loud) I'd maybe added a new validation in validation.yaml, that asserts federation_frontend=true && enterprise=true. But we seem to not do that generally, and I think it won't be too much of an obscure issue for a user, who might set randomly.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov
Copy link
Contributor Author

(Thinking out loud) I'd maybe added a new validation in validation.yaml, that asserts federation_frontend=true && enterprise=true. But we seem to not do that generally, and I think it won't be too much of an obscure issue for a user, who might set randomly.

just to follow-up: I did this in ec08c6e

@dimitarvdimitrov dimitarvdimitrov merged commit 18ba216 into main Nov 11, 2024
31 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/helm/federation-frontend branch November 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants