-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add GEM federation-frontend resources #9673
Conversation
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
bc2b7ea
to
6278ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Looks good to me.
(Thinking out loud) I'd maybe added a new validation in validation.yaml
, that asserts federation_frontend=true && enterprise=true
. But we seem to not do that generally, and I think it won't be too much of an obscure issue for a user, who might set randomly.
...ons/helm/charts/mimir-distributed/ci/offline/test-enterprise-federation-frontend-values.yaml
Show resolved
Hide resolved
...ons/helm/charts/mimir-distributed/templates/federation-frontend/federation-frontend-dep.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
...ederation-frontend-values-generated/mimir-distributed/templates/minio/create-bucket-job.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
just to follow-up: I did this in ec08c6e |
What this PR does
This PR adds the federation-frontend resources to the Helm chart. The goal is to have the federation-frontend deployed on its own.
enabled
toggles for all components so there are no unrelated components deployedI've tested this locally with the
test-enterprise-federation-frontend-values.yaml
(+ license) by deploying a Mimir cluster and pointing the federation-frontend to itWhich issue(s) this PR fixes or relates to
related to #9672
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.