ruler: Support OAuth2 and proxies in Alertmanager client #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still in draft state as I finalize testing. |
alexweav
force-pushed
the
alexweav/ruler-proxy-oauth
branch
from
1499f5b to
1be45db
Compare
alexweav
commented
Nov 25, 2024
pkg/ruler/notifier.go
Outdated
| ClientID string `yaml:"client_id"` | ||
| ClientSecret flagext.Secret `yaml:"client_secret"` | ||
| TokenURL string `yaml:"token_url"` | ||
| Scopes flagext.StringSlice `yaml:"scopes,omitempty"` |
There was a problem hiding this comment.
Note: Moving this to StringSliceCSV. Nearly every other field that behaves this way across the project uses the CSV version, the regular version looks like it doesn't work as cleanly.
francoposa
approved these changes
Nov 25, 2024
|
per discussion we said we would leave adding the support for specifying token audience via client credentials config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The AM client already supports several TLS options + basic auth for talking to Alertmanager.
Extend this to also support OAuth2 Client Credentials Workflow, plus a URL for talking to the Alertmanager through a proxy.
These are all supported in upstream Prometheus's Alertmanager client: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#alertmanager_config
via `http_config: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#alertmanager_config
Supports HTTP, HTTP with CONNECT, or SOCKS5 proxies per https://pkg.go.dev/net/http#Transport. Under the hood,
prometheus/commondoesn't implement anything special for proxies and just wires the configuration up tohttp.Transport's proxy (1, 2)Which issue(s) this PR fixes or relates to
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.