Remove go.mod replace for golang.org/x/exp #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a replace directive for
golang.org/x/expform the Pyroscope's go.mod files.This is necessary because we are upgrading Grafana Agent to a new OpenTelemetry version, and it requires a new version of
github.com/grafana/loki/pkg/pushwhich needs the latestgolang.org/x/exp. However, the Agent also depends on Pyroscope and it won't build correctly unless the Pyroscope is changed to use the latestgolang.org/x/exp.The reason why
golang.org/x/exphas been problematic is because the return type ofSortFuncchanged frombool(in the old version) toint(in the new version). Apparently some packages like to usegolang.org/x/expbecause it's more performant.