feat: Improve compaction shutdown #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
approved these changes
Jan 9, 2024
pkg/compactor/bucket_compactor.go
Outdated
| @@ -539,8 +539,14 @@ func (c *BucketCompactor) runCompactionJob(ctx context.Context, job *Job) (shoul | |||
| if err = verifyCompactedBlocksTimeRanges(compIDs, toCompactMinTime.UnixMilli(), toCompactMaxTime.UnixMilli(), subDir); err != nil { | |||
| level.Warn(jobLogger).Log("msg", "compacted blocks verification failed", "err", err) | |||
There was a problem hiding this comment.
Nit: Should probably be an error:
Suggested change
| level.Warn(jobLogger).Log("msg", "compacted blocks verification failed", "err", err) | |
| level.Error(jobLogger).Log("msg", "compacted blocks verification failed", "err", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen traces where it took 10m to compact. When we rollout a new version it can get cancelled in the upload and deletion which is usually less than 2m.
I think we should leave a grace period for uploads and marking blocks deleted.