chore(examples): Update release-1.10 with changes from /docs #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +64,8 @@ Check your specific language SDK documentation for the exact configuration optio | |||
|
|
|||
| The examples in this section provide samples you can use as a starting point for your own configurations. | |||
|
|
|||
| Explore the [example](https://github.com/grafana/pyroscope/tree/main/examples/language-sdk-instrumentation/golang-push/rideshare-alloy) in our GitHub repository to learn how to configure Grafana Alloy to receive profiles from a Golang application instrumented with Pyroscope. | |||
There was a problem hiding this comment.
Removing "our" in the sentence because we try not to use first person (we, I) in the docs except for things like release notes.
Suggested change
| Explore the [example](https://github.com/grafana/pyroscope/tree/main/examples/language-sdk-instrumentation/golang-push/rideshare-alloy) in our GitHub repository to learn how to configure Grafana Alloy to receive profiles from a Golang application instrumented with Pyroscope. | |
| Explore the [example](https://github.com/grafana/pyroscope/tree/main/examples/language-sdk-instrumentation/golang-push/rideshare-alloy) in the Pyroscope GitHub repository to learn how to configure Grafana Alloy to receive profiles from a Golang application instrumented with Pyroscope. |
There was a problem hiding this comment.
I will provide a separate PR for that
knylander-grafana
approved these changes
Dec 17, 2024
knylander-grafana
added
type/docs
|
This PR must be merged before a backport PR will be created. |
petethepig
approved these changes
Dec 17, 2024
This was referenced Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not always backport the changes, also there was quite a few that were not that atomic.
I suggest we do this: Takes the changes from /docs in main and commit them to the release branch.
Wdyt?