-
Notifications
You must be signed in to change notification settings - Fork 713
chore(helm): replace minio with seaweedfs for object storage #4564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(helm): replace minio with seaweedfs for object storage #4564
Conversation
- Remove minio dependency from Helm chart - Add seaweedfs (v4.0.393) as object storage backend - Update Chart.lock with new dependency resolution
|
Hi @simonswine |
simonswine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all sorry for taking so long to get back to you. Thank you for your contribution.
I have spent quite a bit of time getting this to work end-to-end.
Unfortunately there are a couple of problems:
- This only adds the modue, but doesn't configure it and use it yet
- Requires newer helm chart version
- Upstream helm chart generates random password, that will interfere.
After I discovered some of the problems, I had a try with an alternative, which also was not very straight forward.
Let me know if you would like to pursue seaweedfs or if rustfs could be an alertnative: #4681
Very similar to that PR you would need to touch the values file, need to make sure the chart runs with:
# Code generation
make helm/docs helm/check helm/lint
# Run microservices cell
$make deploy-micro-services
| version: "1.3.1" | ||
| repository: https://grafana.github.io/helm-charts | ||
| condition: alloy.enabled | ||
| - name: minio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would keep minio in here and just switch the usages from minio.enabled to seaweedfs.enabled. So in case anyone using it, can decide when to migrate at their own pace.
Summary
Replace MinIO with SeaweedFS as the object storage backend in Pyroscope Helm chart.
Fixes #4557
Motivation
SeaweedFS offers several advantages for production deployments:
Changes
miniodependency from Chart.yamlseaweedfs(v4.0.393) as the storage backendTesting
make lintpassesmake go/testpasses