Fix clearing instance metrics when namespace is deleted #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
- Coverage 72.94% 72.92% -0.03%
==========================================
Files 106 106
Lines 6575 6577 +2
==========================================
Hits 4796 4796
- Misses 1489 1491 +2
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
iblancasa
approved these changes
Aug 29, 2024
|
@pavolloffay Verified the fix with the steps from the jira issue. We are good to merge the PR. |
| @@ -82,6 +82,8 @@ func (r *TempoStackReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
| log.Error(err, "unable to fetch TempoStack") | |||
| return ctrl.Result{}, fmt.Errorf("could not fetch tempo: %w", err) | |||
| } | |||
| // instance is not found, metrics can be cleared | |||
| status.ClearTempoStackMetrics(req.Namespace, req.Name) | |||
There was a problem hiding this comment.
do we always get a reconcile event on deletion? could we remove the ClearTempoStackMetrics() from the deletion webhook then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1019
The reconciliation loop was run after the deletion webohok causing the instance metric to be set as failed.
The alert
TempoOperatorReconcileErroris still firing, but that is expected.