Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifestutils: configure CA and ServicePKI by name #1039

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

frzifus
Copy link
Collaborator

@frzifus frzifus commented Sep 26, 2024

Roughly what you had in mind?
cc @andreasgerstmayr @IshwarKanse

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.88%. Comparing base (0c5313e) to head (7ac151f).

Files with missing lines Patch % Lines
internal/manifests/manifestutils/service.go 0.00% 18 Missing ⚠️
internal/manifests/queryfrontend/query_frontend.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   73.10%   72.88%   -0.23%     
==========================================
  Files         106      106              
  Lines        6630     6642      +12     
==========================================
- Hits         4847     4841       -6     
- Misses       1493     1511      +18     
  Partials      290      290              
Flag Coverage Δ
unittests 72.88% <9.52%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasgerstmayr
Copy link
Collaborator

andreasgerstmayr commented Sep 27, 2024

Roughly what you had in mind? cc @andreasgerstmayr @IshwarKanse

yes 👍

Probably we should merge it with https://github.com/grafana/tempo-operator/blob/fce6a2af70615d79c01ac17a94b52fa0bc0d317e/internal/manifests/manifestutils/tls.go at some point, which afaics serves (almost?) the same purpose - mounting TLS certs/keys in the container.

@frzifus frzifus merged commit f4cb97c into grafana:main Sep 27, 2024
11 checks passed
@frzifus frzifus deleted the manifestutils branch September 27, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants