Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Test timeout for non-multitenant TempoStack and TempoMonolithic instances. #1049

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

IshwarKanse
Copy link
Contributor

tests/e2e-openshift/route -- Test with custom timeout set to 2m
tests/e2e-openshift/monolithic-route -- Test with custom timeout set to 2m
tests/e2e-openshift/tls-singletenant -- Test default timeout of 30s
tests/e2e-openshift/tls-monolithic-singletenant/ -- Test default timeout of 30s

--- PASS: chainsaw (0.00s)
    --- PASS: chainsaw/monolithic-route (55.16s)
    --- PASS: chainsaw/tls-singletenant-monolithic (96.14s)
    --- PASS: chainsaw/route (138.22s)
    --- PASS: chainsaw/tls-singletenant (164.25s)
PASS
Tests Summary...
- Passed  tests 4
- Failed  tests 0
- Skipped tests 0
Done.

Once the multitenancy issues are fixed, will add the asserts for the multitenancy tests as well.

@IshwarKanse
Copy link
Contributor Author

cc @pavolloffay

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.20%. Comparing base (c7eb01b) to head (de36f35).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1049   +/-   ##
=======================================
  Coverage   69.20%   69.20%           
=======================================
  Files         110      110           
  Lines        7049     7049           
=======================================
  Hits         4878     4878           
  Misses       1881     1881           
  Partials      290      290           
Flag Coverage Δ
unittests 69.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IshwarKanse
Copy link
Contributor Author

Found an issue with Tempo configmap not being serialised in readable format when distributor tls is enabled in TempoStack instance. https://issues.redhat.com/browse/TRACING-4833

wildcardPolicy: None

---
apiVersion: v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we format this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bug as mentioned in the above comment. https://issues.redhat.com/browse/TRACING-4833 without the distributor tls enabled, the formatting is serialised correctly.

@pavolloffay pavolloffay merged commit ff0d0dc into grafana:main Oct 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants