Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Resources: Use OpenAPI client for tests #1322

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Jan 30, 2024

Leaves all the actual code the same, but all he functions in *_test.go files now use the OpenAPI client

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne force-pushed the julienduchesne/cloud-openapi-tests branch 2 times, most recently from 2dea0fe to f492694 Compare January 30, 2024 18:36
@julienduchesne julienduchesne marked this pull request as ready for review January 31, 2024 17:12
@julienduchesne julienduchesne requested a review from a team as a code owner January 31, 2024 17:12
@julienduchesne julienduchesne requested a review from a team January 31, 2024 17:12
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for TDD

@julienduchesne julienduchesne force-pushed the julienduchesne/cloud-openapi-tests branch from fb26ece to eaeb08b Compare February 1, 2024 13:37
@julienduchesne julienduchesne merged commit 271e1f9 into master Feb 1, 2024
25 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/cloud-openapi-tests branch February 1, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants