Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack: Remove Computed attribute on url #1387

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Feb 28, 2024

Since it's computed, it's not available at creation time it seems
That means that when it's set, it's only applied the second time (on update)

By not setting it as computed, it means that Terraform now defaults it as an empty string, so we need to:

  • suppress the diff if we're reverting from the default URL (slug.grafana.net) to an empty string
  • write the default URL in the update function, if we're not specifying a custom stack URL. Seems like the create function is fine with getting passed an empty string for a URL (that was already the case, with the Computed setting)

Test run: https://github.com/grafana/terraform-provider-grafana/actions/runs/8074401925/job/22059643287

Since it's computed, it's not available at creation time it seems
That means that when it's set, it's only applied the second time (on update)
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne marked this pull request as ready for review February 28, 2024 02:37
@julienduchesne julienduchesne requested review from a team as code owners February 28, 2024 02:37
@julienduchesne julienduchesne merged commit 9b37ce0 into main Feb 28, 2024
26 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/remove-computed branch February 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants