Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_stack_service_account: Use new GET and DELETE endpoints #1437

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

julienduchesne
Copy link
Member

Rather than having to POST a temporary service account and using that to do full CRUD management, the gcom now exposes full CRUD capability that we can use.

This means that doing a terraform plan will no longer POST a temporary SA for every cloud_stack_service_account and cloud_stack_service_account_token resource in the state
This should help users that are being throttled by the gcom API

Rather than having to POST a temporary service account and using that to do full CRUD management, the gcom now exposes full CRUD capability that we can use.

This means that doing a `terraform plan` will no longer POST a temporary SA for every `cloud_stack_service_account` and `cloud_stack_service_account_token` resource in the state
This should help users that are being throttled by the gcom API
@julienduchesne julienduchesne requested review from a team as code owners March 22, 2024 15:58
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne
Copy link
Member Author

julienduchesne commented Mar 22, 2024

Testruns:

Copy link
Member

@K-Phoen K-Phoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@julienduchesne julienduchesne merged commit 603ca62 into main Mar 22, 2024
26 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/service-accounts-use-get-delete branch March 22, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants