-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resources for creating ML managed alerts #1670
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
6ea6350
to
0d39ff4
Compare
Same comment as #1653 (comment) 😓 |
7aee19b
to
4d5a724
Compare
ea335d7
to
243d961
Compare
243d961
to
478d0e0
Compare
Ok, updated to use the new framework and got tests passing again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀 A few small things to fix
7aecf96
to
3df2a15
Compare
This generates an example in the documentation for how to create an alert resource.
bf41604
to
1b164fe
Compare
1b164fe
to
14b6b61
Compare
Addressed all the comments but I am running into an OnCall test that seems to be consistently failing:
edit: enough retries and everything passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me Chris, the examples as well.
Had a look at the new resources to try and make sense of the changes.
Let's wait for @julienduchesne to give it another go though in case there is something else though.
No description provided.