Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources for creating ML managed alerts #1670

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Conversation

csmarchbanks
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jul 9, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@csmarchbanks csmarchbanks force-pushed the ml-alert-resources branch 20 times, most recently from 6ea6350 to 0d39ff4 Compare July 9, 2024 19:53
@csmarchbanks csmarchbanks marked this pull request as ready for review July 9, 2024 19:53
@csmarchbanks csmarchbanks requested review from a team as code owners July 9, 2024 19:53
@julienduchesne
Copy link
Member

Same comment as #1653 (comment) 😓

@csmarchbanks csmarchbanks force-pushed the ml-alert-resources branch 4 times, most recently from 7aee19b to 4d5a724 Compare July 10, 2024 14:52
@csmarchbanks csmarchbanks force-pushed the ml-alert-resources branch 3 times, most recently from ea335d7 to 243d961 Compare July 10, 2024 15:27
@csmarchbanks
Copy link
Contributor Author

Ok, updated to use the new framework and got tests passing again.

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 A few small things to fix

@csmarchbanks csmarchbanks force-pushed the ml-alert-resources branch 2 times, most recently from 7aecf96 to 3df2a15 Compare July 10, 2024 20:43
This generates an example in the documentation for how to create an
alert resource.
@csmarchbanks csmarchbanks force-pushed the ml-alert-resources branch 3 times, most recently from bf41604 to 1b164fe Compare July 10, 2024 21:20
@csmarchbanks
Copy link
Contributor Author

csmarchbanks commented Jul 10, 2024

Addressed all the comments but I am running into an OnCall test that seems to be consistently failing:

=== NAME  TestAccDataSourceTeam_Basic
    data_source_team_test.go:17: Step 1/1 error: Error running apply: exit status 1
        
        Error: couldn't find a team matching: test-acc-pgbfl46w
        
          with data.grafana_oncall_team.test-acc-team,
          on terraform_plugin_test.tf line 6, in data "grafana_oncall_team" "test-acc-team":
           6: data "grafana_oncall_team" "test-acc-team" {
        
--- FAIL: TestAccDataSourceTeam_Basic (62.65s)

edit: enough retries and everything passed!

Copy link
Contributor

@ioanarm ioanarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Chris, the examples as well.
Had a look at the new resources to try and make sense of the changes.

Let's wait for @julienduchesne to give it another go though in case there is something else though.

@csmarchbanks csmarchbanks merged commit 2f13039 into main Jul 11, 2024
27 checks passed
@csmarchbanks csmarchbanks deleted the ml-alert-resources branch July 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants