Use up-to-date interface in a template #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
codebien and
joanlopez
and removed request for
a team
codebien
approved these changes
May 16, 2024
joanlopez
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
During the review of the open telemetry output, we figured out the actual output. Since the output interface is deprecated, this PR switches the template to use the right one.
Related discussion: grafana/xk6-output-opentelemetry#3 (comment)
We probably also need to mark the interface Deprecated inside k6, but it's a bit more work since it's embedding + and not all our own output implements it yet.
Why?
Otherwise, we could produce more extensions that implement only a legacy interface.